Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FlexVotingClient governor mutable #48

Open
davidlaprade opened this issue May 17, 2023 · 0 comments
Open

Make FlexVotingClient governor mutable #48

davidlaprade opened this issue May 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@davidlaprade
Copy link
Contributor

davidlaprade commented May 17, 2023 •
edited
Loading

As we know all too well, governors change and the governor address associated with a given governance token and/or timelock can be updated over time.

For this reason, the FlexVotingClient abstract contract should reflect this. Specifically:

  • the GOVERNOR variable should be mutable, not immutable
  • the abstract contract should define a virtual function to update the GOVERNOR value -- we might call it updateGovernor -- which child contracts will be required to implement

This is also needed for better proxy support. There currently is no way to set the GOVERNOR value in an initializer.

This was raised here and here
@davidlaprade davidlaprade mentioned this issue May 17, 2023
Merged
@davidlaprade davidlaprade added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidlaprade