Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Change api url config file option #37

Open
esc opened this issue Dec 29, 2015 · 10 comments
Open

Change api url config file option #37

esc opened this issue Dec 29, 2015 · 10 comments

Comments

@esc
Copy link
Contributor

esc commented Dec 29, 2015

Does anyone have any issues changing the api_url config item to api-url?

@schlomo
Copy link
Contributor

schlomo commented Dec 29, 2015

I would like to have an option to only set the hostname part of the URL - leaving the protocol and path unchanged. ATM I need to set the complete URL even if I only want to change the hostname of the server.

@esc
Copy link
Contributor Author

esc commented Dec 29, 2015

those are separate issues, mind you.

@schlomo
Copy link
Contributor

schlomo commented Dec 29, 2015

Yes? My issue is you want me to change my config and I - the end user - voice my opinion about what kind of change I actually need :-)

So, maybe instead of changing the api_url key you add a new key called api-host (or something like this) that solves my problem and probably the problem of all the other people who ever had to change the api_url key :-)

@schlomo
Copy link
Contributor

schlomo commented Dec 29, 2015

See also #39, though I would love to have a corresponding config item as well.

@esc
Copy link
Contributor Author

esc commented Jan 27, 2016

@schlomo how do we deal with this? Would propose to change this, when we change to v2

@esc
Copy link
Contributor Author

esc commented Jan 27, 2016

But maybe we can deprecate it already?

@schlomo
Copy link
Contributor

schlomo commented Jan 27, 2016

Sure, why not add a deprecation warning for the old form? In 1-2 months we can then remove it.

@schlomo
Copy link
Contributor

schlomo commented Jan 27, 2016

And advice people to switch to the new server variable which will probably obsolete the need for people to change the api-url variable altogether.

@esc
Copy link
Contributor Author

esc commented Jan 27, 2016

Yes, but only if it is found in config, right? I don't want a warning if I am overriding things on the command-line.

@schlomo
Copy link
Contributor

schlomo commented Jan 27, 2016

If you use the old command line argument then you should be warned. Otherwise not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants