Replace afp with afpv2

[esc]

What are every ones thoughts on this one?

[mriehl]

I'd do a 2-step migration:

• afp uses the new cli experience, but afpv1 kept for backwards compatibility
• drop afpv1 (at some point)

Step 1 would allow to find out who is affected (eG numerous scripts). If no one complains then step 2 can be done earlier. People whose workflow is disrupted by the change can still keep using afpv1 but will know that they need to adapt their scripts / workflow.

[esc]

Okay, maybe next tuesday then.

[esc]

Do you know of any scripts that use afpv1?

[mriehl]

We have some, but we can simply change them. I don't have any problems with a hard migration. But who knows what's out there ;)

[esc]

I'd like to come and see some of those scripts, wasn't expecting anyone to automate on afp-cli.

[schlomo]

Can we rename the subshell command to just shell? It is shorter and IMHO clear what it will do.

[schlomo]

Please add an Examples section to the --help command, e.g. eval $(afpv2 export account-name). This will help our users to quickly understand how to use it.

[schlomo]

Who needs the show subcommand? What use case does it serve? If this is for human consumption then I would suggest a format that is much more friendly on the eyes than KEY=VAL. And you also don't need quoting then :-)

If to keep show then probably JSON and YAML output will be more valuable to enable people to parse it in a machine readable format. jq to the rescue :-)

[schlomo]

The write subcommand should actually inform about which file was written and maybe warn if the file is world readable. Or offer setting safe perms automatically.