Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Handle case when keyring password does not work #40

Open
heroldus opened this issue Jan 5, 2016 · 4 comments
Open

Handle case when keyring password does not work #40

heroldus opened this issue Jan 5, 2016 · 4 comments
Milestone

Comments

@heroldus
Copy link

heroldus commented Jan 5, 2016

The keyring feature in #27 is really great. The only pitfall is that the password expiration will come soon. To tackle that you could re-prompt for a password if the authentication on the afp-server fails and save the new password in keyring

@esc
Copy link
Contributor

esc commented Jan 10, 2016

Yes, we should think about improving the handling logic. Right now, it works 80% of the time but it would be nice to make it smarter and less, shall I say "hacky".

@schlomo
Copy link
Contributor

schlomo commented Jan 26, 2016

A simpler solution might be to simple remove the cached password from the keyring if it did not work, together with a suitable message to the user like "Your cached password did not work - removing it. Please try again".

That would follow a "clean up after yourself" mind set without the need for a password changed dialog.

@schlomo
Copy link
Contributor

schlomo commented Jan 26, 2016

ATM the workaround is to manually go to the password keyring and change/delete the password there. IMHO this is too non-obvious.

@schlomo schlomo added this to the 16W4 milestone Jan 27, 2016
@schlomo schlomo changed the title Allow update of passwords in keyring Handle case when keyring password does not work Jan 27, 2016
@schlomo
Copy link
Contributor

schlomo commented Jan 27, 2016

Idea: Simply remove the stored password from keyring if it does not work.

This also covers other cases like the user entering a wrong password or unforeseen troubles.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants