fix: raise an error when duration is non-zero for video assets (#2399)

Author: nicomiguelino

api/errors.py

@@ -0,0 +1,2 @@
+class AssetCreationError(Exception):
+    pass

api/serializers/mixins.py

@@ -4,6 +4,7 @@
 
 from rest_framework.serializers import CharField, Serializer
 
+from api.errors import AssetCreationError
 from lib.utils import (
     download_video_from_youtube,
     get_video_duration,
@@ -74,6 +75,10 @@ def prepare_asset(self, data, asset_id=None, version='v2'):
                 asset['duration'] = (
                     duration if version == 'v2' else int(duration)
                 )
+            else:
+                raise AssetCreationError(
+                    'Duration must be zero for video assets.'
+                )
         else:
             # Crashes if it's not an int. We want that.
             duration = data.get(
@@ -99,7 +104,9 @@ def prepare_asset(self, data, asset_id=None, version='v2'):
         asset['end_date'] = data.get('end_date').replace(tzinfo=None)
 
         if not asset['skip_asset_check'] and url_fails(asset['uri']):
-            raise Exception("Could not retrieve file. Check the asset URL.")
+            raise AssetCreationError(
+                'Could not retrieve file. Check the asset URL.'
+            )
 
         return asset
 

api/tests/test_assets.py

@@ -1,6 +1,7 @@
 """
 Tests for asset-related API endpoints.
 """
+import mock
 from django.test import TestCase
 from django.urls import reverse
 from rest_framework import status
@@ -79,6 +80,48 @@ def test_create_asset_should_return_201(self, version):
         self.assertEqual(response.data['play_order'], 0)
         self.assertEqual(response.data['skip_asset_check'], 0)
 
+    @mock.patch('api.serializers.mixins.rename')
+    @mock.patch('api.serializers.mixins.validate_uri')
+    def test_create_video_asset_v2_with_non_zero_duration_should_fail(
+        self,
+        mock_validate_uri,
+        mock_rename
+    ):
+        """Test that v2 rejects video assets with non-zero duration."""
+        mock_validate_uri.return_value = True
+        asset_list_url = reverse('api:asset_list_v2')
+
+        test_data = {
+            'name': 'Test Video',
+            'uri': '/data/screenly_assets/video.mp4',
+            'start_date': '2019-08-24T14:15:22Z',
+            'end_date': '2029-08-24T14:15:22Z',
+            'duration': 30,
+            'mimetype': 'video',
+            'is_enabled': True,
+            'nocache': False,
+            'play_order': 0,
+            'skip_asset_check': False
+        }
+
+        response = self.client.post(
+            asset_list_url,
+            data=test_data,
+            format='json'
+        )
+
+        self.assertEqual(
+            response.status_code,
+            status.HTTP_500_INTERNAL_SERVER_ERROR
+        )
+        self.assertIn(
+            'Duration must be zero for video assets',
+            str(response.data)
+        )
+
+        self.assertEqual(mock_rename.call_count, 1)
+        self.assertEqual(mock_validate_uri.call_count, 1)
+
     @parametrize_version
     def test_get_assets_after_create_should_return_1_asset(self, version):
         self.create_asset(ASSET_CREATION_DATA, version)