fix(rss-reader): harden cache and CORS proxy handling

- Only apply CORS proxy to absolute http/https URLs
- Use number type for cache_interval to avoid parseInt edge cases
- Wrap saveCache in try/catch to prevent storage errors from breaking renders
- Document legacy cache format behaviour in loadCache

Author: nicomiguelino

edge-apps/rss-reader/src/main.ts

@@ -22,7 +22,9 @@ async function fetchFeed(
 ): Promise<RssEntry[]> {
   const bypassCors =
     getSettingWithDefault<string>('bypass_cors', 'true') === 'true'
-  const url = bypassCors ? `${getCorsProxyUrl()}/${rssUrl}` : rssUrl
+  const isAbsolute = /^https?:/.test(rssUrl)
+  const url =
+    bypassCors && isAbsolute ? `${getCorsProxyUrl()}/${rssUrl}` : rssUrl
 
   const response = await fetch(url)
   if (!response.ok) {
@@ -93,7 +95,7 @@ document.addEventListener('DOMContentLoaded', async () => {
   )
   const rssTitle = getSettingWithDefault<string>('rss_title', 'RSS Feed')
   const cacheInterval =
-    parseInt(getSettingWithDefault<string>('cache_interval', '1800')) * 1000
+    getSettingWithDefault<number>('cache_interval', 1800) * 1000
 
   const loadAndRender = async () => {
     try {

edge-apps/rss-reader/src/utils.ts

@@ -24,13 +24,19 @@ export function loadCache(): RssEntry[] {
     const raw = localStorage.getItem(CACHE_KEY)
     if (!raw) return []
     const parsed: AppCache = JSON.parse(raw)
+    // parsed.entries is undefined if the stored value is a legacy plain array;
+    // falling back to [] causes a fresh fetch on first run after upgrade.
     return parsed.entries ?? []
   } catch {
     return []
   }
 }
 
 export function saveCache(entries: RssEntry[]) {
-  const data: AppCache = { entries, timestamp: Date.now() }
-  localStorage.setItem(CACHE_KEY, JSON.stringify(data))
+  try {
+    const data: AppCache = { entries, timestamp: Date.now() }
+    localStorage.setItem(CACHE_KEY, JSON.stringify(data))
+  } catch (err) {
+    console.warn('Failed to save cache:', err)
+  }
 }