Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Add role type to pid check? #16

Open
kwaping opened this issue Jan 2, 2019 · 1 comment
Open

Add role type to pid check? #16

kwaping opened this issue Jan 2, 2019 · 1 comment

Comments

@kwaping
Copy link
Contributor

kwaping commented Jan 2, 2019

What do you think about adding role type to pid check? In the current state, you can launch a "hub" type, then set it to status stopped with type "node". This seems unsafe.

If you like the idea, I have a PR ready to go, just have to write some tests and docs. I have tested my code functionally and it works great - can start/stop a hub and node on the same machine independently.

@ddavison
Copy link
Member

ddavison commented May 8, 2019

sounds great @kwaping ! no need to wait on me! send that PR if you still have it handy! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants