fix(serialize): fix keys serialization of nested attributes

Author: Vincent Molinié

lib/serializer-utils.js

@@ -239,6 +239,7 @@ module.exports = function (collectionName, record, payload, opts) {
     var embeds = [];
     var attributes = [];
 
+    var ret = {};
     if (opts && opts.attributes) {
       embeds = opts.attributes.filter(function (attr) {
         return opts[attr];
@@ -247,18 +248,17 @@ module.exports = function (collectionName, record, payload, opts) {
       attributes = opts.attributes.filter(function (attr) {
         return !opts[attr];
       });
-    } else {
-      attributes = _keys(dest);
-    }
 
-    var ret = {};
-    if (attributes) { ret.attributes = pick(dest, attributes); }
+      if (attributes) { ret.attributes = pick(dest, attributes); }
 
-    embeds.forEach(function (embed) {
-      if (isComplexType(dest[embed])) {
-        that.serialize(ret, dest, embed, opts[embed]);
-      }
-    });
+      embeds.forEach(function (embed) {
+        if (isComplexType(dest[embed])) {
+          that.serialize(ret, dest, embed, opts[embed]);
+        }
+      });
+    } else {
+      ret.attributes = dest;
+    }
 
     return ret.attributes;
   };

test/serializer.js

@@ -464,6 +464,37 @@ describe('Options', function () {
 
       done(null, json);
     });
+
+    it('should not change keys of nested object if not specified', function (done) {
+      var dataSet = {
+        id: '1',
+        nestedTest: {
+          dontChange: 1
+        },
+        nestedArrayTest: [{
+          dontChange: 1
+        }],
+      };
+
+      var json = new JSONAPISerializer('user', {
+        attributes: ['nestedTest', 'nestedArrayTest'],
+        keyForAttribute: 'underscore_case',
+      }).serialize(dataSet);
+
+      expect(json.data.type).equal('users');
+      expect(json.data).to.have.property('attributes').that.is
+        .an('object')
+        .eql({
+          'nested_test': {
+            dontChange: 1
+          },
+          'nested_array_test': [{
+            dontChange: 1
+          }],
+        });
+
+      done(null, json);
+    });
   });
 
   describe('keyForAttribute case strings', function () {