Fix set multi namespace on single server (#47)

* we aren't setting the namespace correctly on single server optimized set_multi.

* fix private constant as rubocop warns

Author: danmayer

lib/dalli/protocol/base.rb

@@ -24,6 +24,7 @@ def initialize(attribs, client_options = {})
         hostname, port, socket_type, @weight, user_creds = ServerConfigParser.parse(attribs)
         @options = client_options.merge(user_creds)
         @value_marshaller = ValueMarshaller.new(@options)
+        @key_manager = KeyManager.new(@options)
         @connection_manager = ConnectionManager.new(hostname, port, socket_type, @options)
       end
 
@@ -151,9 +152,10 @@ def quiet?
 
       # NOTE: Additional public methods should be overridden in Dalli::Threadsafe
 
+      ALLOWED_QUIET_OPS = %i[add replace set delete incr decr append prepend flush noop].freeze
+
       private
 
-      ALLOWED_QUIET_OPS = %i[add replace set delete incr decr append prepend flush noop].freeze
       def verify_allowed_quiet!(opkey)
         return if ALLOWED_QUIET_OPS.include?(opkey)
 

lib/dalli/protocol/meta.rb

@@ -31,6 +31,8 @@ def write_multi_storage_req(_mode, pairs, ttl = nil, _cas = nil, options = {})
         pairs.each do |key, raw_value|
           (value, bitflags) = @value_marshaller.store(key, raw_value, options)
           encoded_key, _base64 = KeyRegularizer.encode(key)
+          encoded_key = @key_manager.validate_key(encoded_key)
+
           value_bytesize = value.bytesize
           # if last pair of hash, add TERMINATOR
 

test/integration/test_operations.rb

@@ -35,6 +35,28 @@
       end
     end
 
+    it 'set_multi respects namespaces when using raw single server' do
+      memcached_persistent do |_, port|
+        dc = Dalli::Client.new("localhost:#{port}", namespace: 'some:namspace', raw: true)
+        dc.close
+        dc.flush
+
+        pairs = { 'paira' => 'vala', 'pairb' => 'valb', 'pairc' => 'valc' }
+        dc.set_multi(pairs, 5)
+
+        assert_equal pairs, dc.get_multi(pairs.keys)
+      end
+    end
+
+    it 'set_multi respects namespaces on multiple servers' do
+      memcached_persistent do |dc, _port|
+        pairs = { 'paira' => 'vala', 'pairb' => 'valb', 'pairc' => 'valc' }
+        dc.set_multi(pairs, 5)
+
+        assert_equal pairs, dc.get_multi(pairs.keys)
+      end
+    end
+
     it 'return the value that include TERMINATOR on a hit' do
       memcached_persistent do |dc|
         dc.flush