Always set shell to cmd.exe on Windows #2785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
vinistock
force-pushed
the
vs-always-use-cmd-on-windows
branch
from
be6fb84
to
ffcb4b4
Compare
vinistock
force-pushed
the
vs-always-use-cmd-on-windows
branch
from
ffcb4b4
to
c5243e9
Compare
|
Doesn't solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2769
Based on what I can piece together, if you configure PowerShell to be your default shell on Windows, then
execwill use that overcmd.exe, but our activation scripts are only compatible withcmd.exe.This PR ensures that we force Windows activation to always happen on
cmd.exe.Implementation
Started using
cmd.exefor the shell whenever on Windows.Automated Tests
Adapted existing tests.