Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid inside {% schema %} should not be visited by theme-check. #685

Open
charlespwd opened this issue Jan 6, 2025 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@charlespwd
Copy link
Contributor

I think this is somehow related. But since theme blocks are introduced (I think) we can now connect a block value as a default. For instance, inside a section, I have this block:

"blocks": [
    {
      "type": "collection",
      "name": "t:sections.featured_collections.blocks.collection.name",
      "settings": [
        {
          "type": "collection",
          "id": "collection",
          "label": "t:sections.featured_collections.blocks.collection.collection"
        },
        {
          "type": "text",
          "id": "title",
          "label": "t:global.text.title",
          "default": "{{ block.settings.collection.title }}"
        }
  }
]

This is convenient and allow to automatically connect the title with the collection's title of the block.

Theme check report does not currently allow that though:

Image

I am not sure if this is expected @charlespwd

Originally posted by @bakura10 in #624

This is a raw tag that considers liquid differently.

@charlespwd charlespwd added the Bug Something isn't working label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant