Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items can become invisible due to mod compatibility issues #897

Open
asodugf12 opened this issue Apr 20, 2024 · 12 comments · Fixed by #894
Open

Items can become invisible due to mod compatibility issues #897

asodugf12 opened this issue Apr 20, 2024 · 12 comments · Fixed by #894
Labels
bug Something isn't working ui/ux User interface/user experience
Milestone

Comments

@asodugf12
Copy link

asodugf12 commented Apr 20, 2024

Items are not appearing in the creative menu, the EMI menu or the patchouli book either. It seems to only affect things related to tools and weapons, including the tool heads, handles, bindings and the tool itself.
image
image
image
image
image
image

Gems and other pre-generated models seem to be fine, so I am guessing this is an EMI compat issue

Full modlist:
modlist.txt

Tested on Quilt 1.20.1.

@Steveplays28 Steveplays28 added bug Something isn't working ui/ux User interface/user experience labels Apr 20, 2024
@SigmundGranaas
Copy link
Owner

This will be fixed with #894 and released with 0.12 👍
Thanks for the report.

SigmundGranaas added a commit that referenced this issue Apr 22, 2024
## Reworked the context provider system
Closes  #897

Changes:
* Added a new API for providing models with an stack, world and entity
context
* Removed the old dynamicQuadProvider wrapper
* Made models use their wrapping ModelTrasformation
* Simplified the mixins
@aura404dev
Copy link

Hi, still having this issue as of 0.12.1 with EMI on Fabric

modlist.txt

@SigmundGranaas
Copy link
Owner

I'll have another look!

@aura404dev
Copy link

If it serves as context, sometimes models appear then dissapear when opening/closing the inventory and crafting table, initially it correctly showed most models, then only those that were craftable, then most turned invisible after playing a bit. After a while a lot of the models were visually replaced by a cobblestone axe that I previously made, so that's weird.

@JorisDeBeer
Copy link
Collaborator

JorisDeBeer commented Jul 29, 2024

Could you try this again with modelStrategy set to "NO_CACHE" or "FULLY_ASYNC" in forgero's settings?

@aura404dev
Copy link

Same issue with both settings
image

@JorisDeBeer
Copy link
Collaborator

and your modlist? Do keep in mind if this is a quilt issue we are not gonna fix this. Quilt compatibilty is just there, we dont do anything special for that.

I tested again on fabric with only emi and forgero and that works fine

@aura404dev
Copy link

I appended the modlist in my initial comment, I'll try to reproduce the issue later with a smaller mod set.

@JorisDeBeer
Copy link
Collaborator

Ah sorry my bad! In the modlist there is nothing that should really clash in the first place. The first time this happend (when the issue was made) it was a very weird conflict with a mod called SimpleHats. So I am guessing this is another weird modconflict.

That or our earlier fix didnt actually work on quilt in some way.

@Steveplays28 Steveplays28 added this to the 0.13.0 milestone Aug 8, 2024
@Steveplays28 Steveplays28 changed the title [Quilt 1.20.1] Most items are invisible Items can become invisible due to mod compatibility issues Aug 8, 2024
@temyy
Copy link
Contributor

temyy commented Aug 8, 2024

i played around with emi and forgero in a rather large modpack on fabric and found that EMI displaying the items in the sidebar is very inconsistent, sometimes it would display everything except the first item on a page, adding continuity to a pack would not show any of them and something else was causing the items to show only occasionally (for example disappearing when looking at how to craft an item). this might be an issue on EMIs side or some very obscure item rendering issue in forgero as this is kind of difficult to reproduce reliably

@darceno
Copy link

darceno commented Aug 30, 2024

With the new VS2 patch, I finally put Forgero in my modpack to sadly encounter this issue too.

Here are some observations I made that should be reproducible and that may help with debugging:

  • If you have Sodium and EMI installed, the first Forgero item in an EMI page will almost always be invisible. No Sodium option can change that
  • If you have EMI and Continuity installed, most Forgero's tools will not render in EMI, but only if you're using Continuity's Emissive feature, like having a mod like Supplementaries installed or using a Glowing Ores resourcepack. Disabling Emissive Textures in Continuity solves this issue

It seems there is two separate problems, one with Sodium and one with Continuity. A fix would be much appreciated, especially for the Continuity case, which is the most severe.

@JorisDeBeer
Copy link
Collaborator

Someone in the discord has found a temporary fix for the issue with continuity.

For now disable batched rendering in the emi config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux User interface/user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants