Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our own arrows cant be given potion effects #932

Open
Tracked by #928
JorisDeBeer opened this issue Jul 12, 2024 · 6 comments
Open
Tracked by #928

Our own arrows cant be given potion effects #932

JorisDeBeer opened this issue Jul 12, 2024 · 6 comments
Labels
enhancement Improving existing features

Comments

@JorisDeBeer
Copy link
Collaborator

I am not sure how we would implement this.

@JorisDeBeer JorisDeBeer changed the title Our own arrows can be given potion effects Our own arrows cat be given potion effects Jul 12, 2024
@JorisDeBeer JorisDeBeer changed the title Our own arrows cat be given potion effects Our own arrows cant be given potion effects Jul 12, 2024
@SigmundGranaas
Copy link
Owner

Hold my json

@Steveplays28 Steveplays28 added the enhancement Improving existing features label Jul 12, 2024
@SigmundGranaas
Copy link
Owner

image

Fermented spider eye json:

    "features": [
      {
        "type": "minecraft:on_hit",
        "on_hit": {
          "type": "minecraft:status_effect",
          "target": "minecraft:targeted_entity",
          "effect": "minecraft:poison",
          "level": 1
        },
        "title": "Poison",
        "description": "Applies poison on hit"
      }
    ]

Mastercrafted arrow head json:

"slots": [
      {
        "category": [
          "OFFENSIVE"
        ],
        "description": "upgrade",
        "type": "UPGRADE_MATERIAL",
        "tier": 1
      }
    ]

image

Screencast.from.2024-08-22.13-02-29.mp4

@JorisDeBeer
Copy link
Collaborator Author

how does this scale with the arrows? Do they get alot heavier because of the added weight?

@SigmundGranaas
Copy link
Owner

We can adjust the upgrade weight, it's currently at 10.

@JorisDeBeer
Copy link
Collaborator Author

Shall I add this to the handler branch I was working on recently? This adds alot of the status effects from minecraft itself. So I will just add the upgrade slots on arrows on that too

@SigmundGranaas
Copy link
Owner

That would probably work well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing features
Projects
None yet
Development

No branches or pull requests

3 participants