Skip to content

Commit 75ab4c9

Browse files
Use timeout from PerformCommissioningStep for kReadCommissioningInfo reads (#36812)
Fixes #36803
1 parent 7ceaf6f commit 75ab4c9

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/controller/CHIPDeviceController.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -2344,8 +2344,7 @@ void DeviceCommissioner::ContinueReadingCommissioningInfo(const CommissioningPar
23442344
mReadCommissioningInfoProgress = kReadProgressNoFurtherAttributes;
23452345
}
23462346

2347-
const auto timeout = MakeOptional(app::kExpectedIMProcessingTime); // TODO: Save timeout from PerformCommissioningStep?
2348-
SendCommissioningReadRequest(mDeviceBeingCommissioned, timeout, builder.paths(), builder.size());
2347+
SendCommissioningReadRequest(mDeviceBeingCommissioned, mCommissioningStepTimeout, builder.paths(), builder.size());
23492348
}
23502349

23512350
namespace {
@@ -3004,9 +3003,10 @@ void DeviceCommissioner::PerformCommissioningStep(DeviceProxy * proxy, Commissio
30043003
params.GetCompletionStatus().err.AsString());
30053004
}
30063005

3007-
mCommissioningStage = step;
3008-
mCommissioningDelegate = delegate;
3009-
mDeviceBeingCommissioned = proxy;
3006+
mCommissioningStepTimeout = timeout;
3007+
mCommissioningStage = step;
3008+
mCommissioningDelegate = delegate;
3009+
mDeviceBeingCommissioned = proxy;
30103010

30113011
// TODO: Extend timeouts to the DAC and Opcert requests.
30123012
// TODO(cecille): We probably want something better than this for breadcrumbs.

src/controller/CHIPDeviceController.h

+1
Original file line numberDiff line numberDiff line change
@@ -838,6 +838,7 @@ class DLL_EXPORT DeviceCommissioner : public DeviceController,
838838
DeviceProxy * mDeviceBeingCommissioned = nullptr;
839839
CommissioneeDeviceProxy * mDeviceInPASEEstablishment = nullptr;
840840

841+
Optional<System::Clock::Timeout> mCommissioningStepTimeout; // Note: For multi-interaction steps this is per interaction
841842
CommissioningStage mCommissioningStage = CommissioningStage::kSecurePairing;
842843
uint8_t mReadCommissioningInfoProgress = 0; // see ContinueReadingCommissioningInfo()
843844

0 commit comments

Comments
 (0)