Fixing IE issue, where cookie values were not read correctly because

carhartl · carhartl · commit fd254ddffcda · 2012-10-12T15:54:01.000+02:00
of duplicate occurrences of "; ", fixes carhartl#88, fixes carhartl#117.
diff --git a/jquery.cookie.js b/jquery.cookie.js
@@ -48,7 +48,8 @@
 		// read
 		var decode = config.raw ? raw : decoded;
 		var cookies = document.cookie.split('; ');
-		for (var i = 0, parts; (parts = cookies[i] && cookies[i].split('=')); i++) {
+		for (var i = 0, l = cookies.length; i < l; i++) {
+			var parts = cookies[i].split('=');
 			if (decode(parts.shift()) === key) {
 				var cookie = decode(parts.join('='));
 				return config.json ? JSON.parse(cookie) : cookie;
diff --git a/sandbox.html b/sandbox.html
@@ -0,0 +1,18 @@
+<!doctype html>
+<html>
+	<head>
+		<title></title>
+		<script src="http://code.jquery.com/jquery-1.7.2.min.js"></script>
+		<script src="jquery.cookie.js"></script>
+		<script>
+			try {
+				Object.defineProperty(document, "cookie", { get: function() { return "first=one; ; second=two"; } });
+				window.testValue = $.cookie("second");
+				window.ok = true;
+			} catch (er) {
+			}
+		</script>
+	</head>
+	<body>
+	</body>
+</html>
diff --git a/test.js b/test.js
@@ -67,6 +67,24 @@ test('json: true', 1, function () {
 	}
 });
 
+asyncTest('malformed cookie value in IE (#88, #117)', 1, function() {
+	// Sandbox in an iframe so that we can poke around with document.cookie.
+	var iframe = document.createElement('iframe');
+	iframe.onload = function() {
+		start();
+		if (iframe.contentWindow.ok) {
+			equal(iframe.contentWindow.testValue, 'two', 'reads all cookie values, skipping duplicate occurences of "; "');
+		} else {
+			// Skip the test where we can't stub document.cookie using
+			// Object.defineProperty. Seems to work fine in
+			// Chrome, Firefox and IE 8+.
+			ok(true, 'N/A');
+		}
+	};
+	iframe.src = '/sandbox.html';
+	document.body.appendChild(iframe)
+});
+
 
 module('write', before);
 
