Skip to content

Commit 4fd33a5

Browse files
SimplicityGuyclaude
andcommitted
fix(e2e): increase page.goto timeout to 30s in explore UI tests
Webkit on macOS CI runners was timing out on page navigation with the 10s timeout. Standardize all page.goto calls to 30s to match the pattern used elsewhere in the test suite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 3c03d9a commit 4fd33a5

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

tests/explore/test_explore_ui.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class TestExploreUI:
1313

1414
def test_page_loads(self, page: Page, test_server: str) -> None:
1515
"""Test that the explore page loads successfully."""
16-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
16+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
1717
expect(page).to_have_title(re.compile("Explore", re.IGNORECASE))
1818

1919
def test_navbar_visible(self, page: Page, test_server: str) -> None:
@@ -25,14 +25,14 @@ def test_navbar_visible(self, page: Page, test_server: str) -> None:
2525

2626
def test_search_input_visible(self, page: Page, test_server: str) -> None:
2727
"""Test that the search input is visible."""
28-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
28+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
2929

3030
search_input = page.locator("#searchInput")
3131
expect(search_input).to_be_visible(timeout=5000)
3232

3333
def test_search_type_dropdown(self, page: Page, test_server: str) -> None:
3434
"""Test the search type dropdown works."""
35-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
35+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
3636

3737
# Find the search type button
3838
type_btn = page.locator("#searchTypeBtn")
@@ -62,7 +62,7 @@ def test_pane_switching(self, page: Page, test_server: str) -> None:
6262

6363
def test_graph_placeholder_visible(self, page: Page, test_server: str) -> None:
6464
"""Test that the graph placeholder is shown before search."""
65-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
65+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
6666

6767
placeholder = page.locator("#graphPlaceholder")
6868
expect(placeholder).to_be_visible(timeout=5000)
@@ -90,7 +90,7 @@ def test_responsive_layout(self, page: Page, test_server: str) -> None:
9090

9191
def test_info_panel_hidden_by_default(self, page: Page, test_server: str) -> None:
9292
"""Test that the info panel is hidden before any node is clicked."""
93-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
93+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
9494

9595
info_panel = page.locator("#infoPanel")
9696
# The panel exists but should not have the 'open' class
@@ -190,7 +190,7 @@ class TestExploreSearchInteraction:
190190

191191
def test_search_type_switching(self, page: Page, test_server: str) -> None:
192192
"""Test switching between search types via dropdown."""
193-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
193+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
194194

195195
type_btn = page.locator("#searchTypeBtn")
196196
expect(type_btn).to_have_text("Artist", timeout=5000)
@@ -218,7 +218,7 @@ def test_search_type_switching(self, page: Page, test_server: str) -> None:
218218

219219
def test_autocomplete_shows_results(self, page: Page, test_server: str) -> None:
220220
"""Test that typing in search shows autocomplete results."""
221-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
221+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
222222

223223
search_input = page.locator("#searchInput")
224224
search_input.fill("Radio")
@@ -233,7 +233,7 @@ def test_autocomplete_shows_results(self, page: Page, test_server: str) -> None:
233233

234234
def test_autocomplete_item_click_triggers_search(self, page: Page, test_server: str) -> None:
235235
"""Test that clicking an autocomplete item triggers a search."""
236-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
236+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
237237

238238
search_input = page.locator("#searchInput")
239239
search_input.fill("Radio")
@@ -255,7 +255,7 @@ def test_autocomplete_item_click_triggers_search(self, page: Page, test_server:
255255

256256
def test_graph_appears_after_search(self, page: Page, test_server: str) -> None:
257257
"""Test that the graph appears after performing a search."""
258-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
258+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
259259

260260
search_input = page.locator("#searchInput")
261261
search_input.fill("Radio")
@@ -277,7 +277,7 @@ def test_graph_appears_after_search(self, page: Page, test_server: str) -> None:
277277

278278
def test_trends_pane_search(self, page: Page, test_server: str) -> None:
279279
"""Test searching on the Trends pane loads chart data."""
280-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
280+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
281281

282282
# Switch to trends pane
283283
trends_link = page.locator("[data-pane='trends']")
@@ -312,7 +312,7 @@ def test_graph_legend_visible(self, page: Page, test_server: str) -> None:
312312

313313
def test_trends_placeholder_visible(self, page: Page, test_server: str) -> None:
314314
"""Test that the trends placeholder is visible before search."""
315-
page.goto(test_server, wait_until="domcontentloaded", timeout=10000)
315+
page.goto(test_server, wait_until="domcontentloaded", timeout=30000)
316316

317317
# Switch to trends pane
318318
trends_link = page.locator("[data-pane='trends']")

0 commit comments

Comments
 (0)