fix: broken /static/brand/ paths, narrow account settings, blank 2FA QR#296
Merged
SimplicityGuy merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
StaticFiles is mounted at `/` in dashboard and explore, so references to `/static/brand/...` resolved to a non-existent nested directory — logos and favicons were broken throughout the rebrand added in PR #295. Fixed in admin.html, index.html, and both site.webmanifest files. Account Settings pane was constrained to 42rem and centered, ignoring most of the viewport. Removed the max-width cap and wrapped cards in a responsive grid that tiles to fit available width. The 2FA setup QR code rendered as a blank white square because the client read `provisioning_uri` while the API returns `otpauth_uri`. QRCode library received `undefined` and drew an empty canvas. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
E2E Coverage (webkit)
|
Contributor
E2E Coverage (chromium)
|
Contributor
E2E Coverage (firefox)
|
Contributor
E2E Coverage (webkit - iPad Pro 11)
|
Contributor
E2E Coverage (webkit - iPhone 15)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/in dashboard and explore, so/static/brand/...resolved to a non-existent nestedstatic/static/brand/path. Fixed inadmin.html, bothindex.htmlfiles, and bothsite.webmanifestfiles..settings-pagehadmax-width: 42remforcing a narrow centered column. Removed the cap and wrapped the three cards (Profile, Password, 2FA) in a.settings-gridthat tiles withauto-fit, minmax(28rem, 1fr).this._setupData.provisioning_uribut the API/api/auth/2fa/setupreturnsotpauth_uri. QRCode library receivedundefined→ empty white canvas. Field name fixed insettings.js.Test plan
/admin— logo + favicons render🤖 Generated with Claude Code