Skip to content

Commit 3291a42

Browse files
committed
BUG: correct zero-arrays definitions that caused submillimeter errors in two algorithms
1 parent 104f5a2 commit 3291a42

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

BoneReconstructionPlanner/BoneReconstructionPlanner.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1104,8 +1104,8 @@ def transformFibulaPlanes(self):
11041104
mandiblePlanesOriginsAreTheSame = False
11051105
else:
11061106
for mandiblePlaneIndex in range(len(planeList)):
1107-
lastMandiblePlanePosition = np.array([0,0,0])
1108-
mandiblePlanePosition = np.array([0,0,0])
1107+
lastMandiblePlanePosition = np.zeros(3)
1108+
mandiblePlanePosition = np.zeros(3)
11091109
lastMandiblePlanesPositionCurve.GetNthControlPointPosition(mandiblePlaneIndex,lastMandiblePlanePosition)
11101110
planeList[mandiblePlaneIndex].GetOrigin(mandiblePlanePosition)
11111111
if np.linalg.norm(lastMandiblePlanePosition-mandiblePlanePosition) > 1e-5:
@@ -1469,8 +1469,8 @@ def transformFibulaPlanes(self):
14691469

14701470
mandibleAxisToFibulaRotationMatrix = self.getAxes1ToAxes2RotationMatrix(mandibleAxisToWorldRotationMatrix, fibulaToWorldRotationMatrix)
14711471

1472-
fibulaPlaneAPosition = np.array([0,0,0])
1473-
fibulaPlaneBPosition = np.array([0,0,0])
1472+
fibulaPlaneAPosition = np.zeros(3)
1473+
fibulaPlaneBPosition = np.zeros(3)
14741474
lastFibulaPlanesPositionA.GetNthControlPointPosition(i,fibulaPlaneAPosition)
14751475
lastFibulaPlanesPositionB.GetNthControlPointPosition(i,fibulaPlaneBPosition)
14761476
self.fibulaPlanesPositionA.append(fibulaPlaneAPosition)
@@ -1750,8 +1750,8 @@ def createAndUpdateDynamicModelerNodes(self):
17501750
modelDisplayNode.SetColor(color)
17511751

17521752
#Determinate plane creation direction and set up dynamic modeler
1753-
planeOriginStart = np.array([0,0,0])
1754-
planeOriginEnd = np.array([0,0,0])
1753+
planeOriginStart = np.zeros(3)
1754+
planeOriginEnd = np.zeros(3)
17551755
planeList[0].GetNthControlPointPosition(0,planeOriginStart)
17561756
planeList[len(planeList)-1].GetNthControlPointPosition(0,planeOriginEnd)
17571757
closestCurvePointStart = [0,0,0]
@@ -2344,8 +2344,8 @@ def createMiterBoxesFromFibulaPlanes(self):
23442344
duplicateFibulaBonePiecesList = createListFromFolderID(duplicateFibulaBonePiecesModelsFolder)
23452345

23462346
for i in range(1,len(duplicateFibulaBonePiecesList)):
2347-
lineStartPos = np.array([0,0,0])
2348-
lineEndPos = np.array([0,0,0])
2347+
lineStartPos = np.zeros(3)
2348+
lineEndPos = np.zeros(3)
23492349
fibulaPlanesList[i*2].GetOrigin(lineStartPos)
23502350
fibulaPlanesList[i*2 +1].GetOrigin(lineEndPos)
23512351
#Create fibula axis:
@@ -2409,8 +2409,8 @@ def createMiterBoxesFromFibulaPlanes(self):
24092409

24102410
for i in range(len(fibulaPlanesList)):
24112411
if useMoreExactVersionOfPositioningAlgorithmChecked:
2412-
lineStartPos = np.array([0,0,0])
2413-
lineEndPos = np.array([0,0,0])
2412+
lineStartPos = np.zeros(3)
2413+
lineEndPos = np.zeros(3)
24142414
fibulaPlanesList[(i//2)*2].GetOrigin(lineStartPos)
24152415
fibulaPlanesList[(i//2)*2 +1].GetOrigin(lineEndPos)
24162416
#Create fibula axis:

0 commit comments

Comments
 (0)