Cargo is not filtering Vanilla Enchanted Books (All treated as same with/without Lore filter)

[NathZen]

❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Cargo doesn't fillter Enchanted Books per enchant. All Enchant were merged into 1 chest that has any enchanted book filter in it

📑 Reproduction Steps

1. Place the chest and fill it with several different enchanted books
2. Connect the Cargo Node (Input) to the chest and enable the blacklist in it.
3. Place some chest and connect the Advanced Cargo Node (Output) to it
4. Insert 1 type of enchanted book per cargo on each chest into the whitelist filter.

💡 Expected Behavior

The cargo distinguish the Enchanted Book

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.16.x

⭐ Slimefun version

🧭 Other plugins

No response

[kylemarham]

Can this bug be reviewed please? 13 months later no update.

[Boomer-1]

there is no issue here. They work fine. I've had a setup for over a year going from level 3 to 15 and not once had an issue

[Boomer-1]

if you can provide video evidence of it not working i will leave this open. All node configurations must be captured clearly, showing every setup and book in each one,, and verification the nodes are connected to the cargo network,

[kylemarham]

Please see the below link

https://streamable.com/zs5ssd

The expected behaviour is that Smite 4 is inserted into the Advanced Cargo Node (Output), but the cargo node feeds Smite 3 books into the book binder instead.

[Boomer-1]

Their server is 6 months behind. Ill leave this open waiting on confirmation of the issue on dev 1035.

[kylemarham]

Can confirm this is still an issue on version 1035

https://streamable.com/r05bnm

[J3fftw1]

I think the best way to solve this issue is to add a same enchant filter instead of a lore check.
Enchants arent really lore so we have to check it differently aswell
If we go this route we could just make it if there are 2 enchants it will just choose between 1 if thats filtered.
If anyone can think of another option throw it in the comments.

[Phoenix-Starlight]

My idea is that if an enchanted book matches the enchantment filter irregardless of extra enchantments or levels then it passes through.

…

On Sat, Jan 21, 2023 at 2:48 PM J3fftw ***@***.***> wrote: I think the best way to solve this issue is to add a same enchant filter instead of a lore check. Enchants arent really lore so we have to check it differently aswell If we go this route we could just make it if there are 2 enchants it will just choose between 1 if thats filtered. If anyone can think of another option throw it in the comments. — Reply to this email directly, view it on GitHub <#3341 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APNXOJAORAKP25FGO5L42OLWTRRSNANCNFSM5HPHC3MQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[J3fftw1]

okay i will give it a look

[Boomer-1]

if more than 1 enchantment, maybe bypass it. Most players when sorting enchantment books put the same in one storage. If i'm sorting eff 5, and i have a second book that's eff 5 mending, unb 3, i'd want it to not go in with the eff 5 books.

[kylemarham]

Can NBT data not be used when the cargo nodes encounter the minecraft:enchanted_book item?

If item in filter is enchanted_book and has NBT data, check NBT data for a match, if it matches, allow the item through?

From what I can see from looking through the plugin, it looks like potions are already handled the way that enchanted books should be.