Fix NPE when no divisions exist (#148)

Author: mallusrgreatv2

Plugin/src/main/java/dev/lrxh/neptune/feature/divisions/DivisionService.java

@@ -65,6 +65,7 @@ public void save() {
     }
 
     public Division getDivisionByElo(int elo) {
+        if (divisions.isEmpty()) return null;
         for (Division division : divisions) {
             if (elo >= division.getEloRequired()) {
                 return division;

Plugin/src/main/java/dev/lrxh/neptune/game/kit/menu/button/StatButton.java

@@ -35,7 +35,7 @@ public ItemStack getItemStack(Player player) {
                         new Replacement("<deaths>", String.valueOf(data.getDeaths())),
                         new Replacement("<win_streak_current>", String.valueOf(data.getCurrentStreak())),
                         new Replacement("<win_streak_best>", String.valueOf(data.getBestStreak())),
-                        new Replacement("<division>", String.valueOf(data.getDivision().getDisplayName())),
+                        new Replacement("<division>", data.getDivision() == null ? "None" : String.valueOf(data.getDivision().getDisplayName())),
                         new Replacement("<played>", String.valueOf(data.getWins() + data.getLosses())),
                         new Replacement("<kill_death_ratio>", String.valueOf(data.getKdr()))), player)
 

Plugin/src/main/java/dev/lrxh/neptune/profile/data/KitData.java

@@ -100,6 +100,7 @@ public boolean updateElo(boolean won) {
     }
 
     public boolean updateDivision() {
+        if (DivisionService.get().divisions.isEmpty()) return false;
         Division previous = this.division;
         Division updated = DivisionService.get().getDivisionByElo(elo);
         if (updated == null) {

Plugin/src/main/java/dev/lrxh/neptune/providers/placeholder/PlaceholderUtil.java

@@ -58,12 +58,14 @@ public String format(String line, Player player) {
             return line;
         ProfileState state = profile.getState();
 
+        Division division = profile.getGameData().getGlobalStats().getDivision();
+
         line = line.replaceAll("<online>", String.valueOf(Bukkit.getServer().getOnlinePlayers().size()));
         line = line.replaceAll("<queued>", String.valueOf(QueueService.get().getQueueSize()));
         line = line.replaceAll("<in-match>", String.valueOf(MatchService.get().matches.size()));
         line = line.replaceAll("<player>", player.getName());
         line = line.replaceAll("<ping>", String.valueOf((PlayerUtil.getPing(player))));
-        line = line.replaceAll("<division>", profile.getGameData().getGlobalStats().getDivision().getDisplayName());
+        line = line.replaceAll("<division>", division == null ? "None" : division.getDisplayName());
 
         GlobalStats globalStats = profile.getGameData().getGlobalStats();
         line = line.replaceAll("<wins>", String.valueOf(globalStats.getWins()));
@@ -100,8 +102,9 @@ public String format(String line, Player player) {
             Participant participant = match.getParticipant(player.getUniqueId());
 
             line = line.replaceAll("<maxPoints>", String.valueOf(match.getRounds()));
+            Division kitDivision = profile.getGameData().get(match.getKit()).getDivision();
             line = line.replaceAll("<kit_division>",
-                    profile.getGameData().get(profile.getMatch().getKit()).getDivision().getDisplayName());
+                    kitDivision == null ? "None" : kitDivision.getDisplayName());
             if (match instanceof SoloFightMatch soloFightMatch) {
                 Participant red = soloFightMatch.getParticipantA();
                 Participant blue = soloFightMatch.getParticipantB();

Plugin/src/main/java/dev/lrxh/neptune/providers/placeholder/impl/DivisionPlaceholder.java

@@ -17,6 +17,6 @@ public String parse(OfflinePlayer player, String string) {
         Profile profile = API.getProfile(player.getUniqueId());
         if (profile == null) return string;
         GlobalStats globalStats = profile.getGameData().getGlobalStats();
-        return String.valueOf(globalStats.getDivision().getDisplayName());
+        return globalStats.getDivision() == null ? "null" : String.valueOf(globalStats.getDivision().getDisplayName());
     }
 }

Plugin/src/main/java/dev/lrxh/neptune/providers/placeholder/impl/KitDivisionPlaceholder.java

@@ -28,6 +28,6 @@ public String parse(OfflinePlayer player, String string) {
         KitData data = profile.getGameData().get(KitService.get().getKitByName(matcher.group(1)));
         if (data == null) return string;
 
-        return data.getDivision().getDisplayName();
+        return data.getDivision() == null ? "null" : String.valueOf(data.getDivision().getDisplayName());
     }
 }