Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a dedicated lib for forms #510

Open
timea-solid opened this issue Jul 22, 2022 · 5 comments
Open

Create a dedicated lib for forms #510

timea-solid opened this issue Jul 22, 2022 · 5 comments

Comments

@timea-solid
Copy link
Member

Separate the forms code out of solid-ui into its own lib. This would allow faster loading of it and easier reuse. See discussion: https://gitter.im/solid/solidos?at=62d9064b76cd751a2f55cee9

Just for the record: Jeff had ideas to improve the form with this jeff-zucker/solid-ui-components#15

@timea-solid
Copy link
Member Author

Another feature idea: #509

@jeff-zucker
Copy link
Contributor

jeff-zucker commented Jul 22, 2022

I generally like this idea but here's what I wonder : in almost all use cases one needs to be authenticated to use a form so if forms are split off then most users will need to also import the inrupt libraries. Are we saving them anything by having the forms separate or would they just need to put most of solid-ui back to use authenticated forms? It may be good for logical reasons but I'm not sure it will solve the size/deployment issues.

@timea-solid
Copy link
Member Author

solid-forms, like solid-ui would be using solid-logic. (for now this is the only dependency I see necessary)

@jeff-zucker
Copy link
Contributor

So other than forms and solid-logic and rdflib and the inrupt library, what does that leave in solid-ui itself and is what it leaves a large byte-size saver compared to all those other heavy-lifters which would be in solid-forms? (I'm not arguing against doing this, just suggesting that optimization of size may not be one of its benefits)

@timea-solid
Copy link
Member Author

Solid-ui has a lot of extra code which solid-forms would not need. But to be honest I do not know how how much less in size it will be.
One other advantage: solid-forms will be easier to read and code in, easier to find your way around, hopefully

@timea-solid timea-solid removed the forms label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants