Skip to content

Commit 0d9a9b0

Browse files
committed
fix typing issues in scannerengine
1 parent 13f099c commit 0d9a9b0

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/pysonar_scanner/scannerengine.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,10 @@ def run(self, config: dict[str, Any]):
144144
return CmdExecutor(cmd, properties_str).execute()
145145

146146
def __build_command(self, jre_path: JREResolvedPath, scanner_engine_path: pathlib.Path) -> list[str]:
147-
cmd = []
148-
cmd.append(jre_path.path)
147+
cmd: list[str] = []
148+
cmd.append(str(jre_path.path))
149149
cmd.append("-jar")
150-
cmd.append(scanner_engine_path)
150+
cmd.append(str(scanner_engine_path))
151151
return cmd
152152

153153
def __config_to_json(self, config: dict[str, Any]) -> str:

tests/unit/test_scannerengine.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,15 @@ def test_command_building(self, execute_mock):
152152
]
153153
}
154154
)
155+
java_path = pathlib.Path("jre/bin/java")
155156
jre_resolve_path_mock = Mock()
156-
jre_resolve_path_mock.path = pathlib.Path("jre/bin/java")
157+
jre_resolve_path_mock.path = java_path
157158
scanner_engine_mock = pathlib.Path("/test/scanner-engine.jar")
158159

159160
scannerengine.ScannerEngine(jre_resolve_path_mock, scanner_engine_mock).run(config)
160161

161162
execute_mock.assert_called_once_with(
162-
[pathlib.Path("jre/bin/java"), "-jar", pathlib.Path("/test/scanner-engine.jar")], expected_std_in
163+
[str(java_path), "-jar", str(pathlib.Path("/test/scanner-engine.jar"))], expected_std_in
163164
)
164165

165166

0 commit comments

Comments
 (0)