Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for + ! operator in meta #93

Open
ashleyse2016 opened this issue May 22, 2018 · 2 comments
Open

Add support for + ! operator in meta #93

ashleyse2016 opened this issue May 22, 2018 · 2 comments

Comments

@ashleyse2016
Copy link

Currently OA does not allow for the operator + ! in the meta part.

Eg:

meta OA_LOCAL_EXAMPLE __OA_LOCAL_EXAMPLE_02 && __OA_LOCAL_EXAMPLE_03 && (( __OA_LOCAL_EXAMPLE_01  + ! __OA_LOCAL_EXAMPLE_08 )

Changing to + ~ works, as would && ! however + ! should also be allowed.

bitsikas added a commit that referenced this issue Feb 25, 2019
…pplies to the rule before doing other operations
@georges96 georges96 self-assigned this Feb 28, 2019
@georges96
Copy link

Complex rules using this rule are failing therefore the daemon fails to start. An example of such rule is
body __LOCAL_TEST1 /\btest1\b/ body __LOCAL_TEST2 /\btest2\b/ body __LOCAL_TEST3 /\btest3\b/ meta LOCAL_MULTIPLE_TESTS (((0.8 * __LOCAL_TEST1) + !(0.5 * __LOCAL_TEST2)) > 1) score LOCAL_MULTIPLE_TESTS 0.1
The rule works fine if i use + ~ instead of + !. My guess here is that the round brackets are affecting the regex or something.

@georges96 georges96 removed their assignment Mar 1, 2019
@georges96
Copy link

However the operator + ! seems to work for simple rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants