Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Code structure #29

Open
Greybird opened this issue Mar 19, 2020 · 1 comment
Open

Question: Code structure #29

Greybird opened this issue Mar 19, 2020 · 1 comment

Comments

@Greybird
Copy link
Contributor

Hello,

Correct me if I'm wrong, but I understand that keeping all code in a single file is meant to ease embedding BoDi as a source file in a consuming project.

As this hurt readability of PRs (I hit that for #24), did you consider publishing a source nuget to allow embedding BoDi as source code for people not wanting to rely on the binary form ?
Example of such source code package can be found here: https://www.nuget.org/packages/Microsoft.Azure.WebJobs.Sources/

I'm not aware of any good reason to do this except to share code that is meant to be private a a repo while still needing to be share, which seems not the case here, but in case this would help to provide more readable contributions...

Regards,

@craigfowler
Copy link

FYI this was suggested nearly 3 years ago as #9 and there's some commentary there about it. Perhaps it is high time to reconsider. AFAIK SpecFlow dotnet core support is completed and has been for quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants