Get one repository

Author: ralphavalon

Diff for: pom.xml

@@ -50,6 +50,10 @@
 			<artifactId>gson</artifactId>
 			<scope>test</scope>
 		</dependency>
+		<dependency>
+			<groupId>org.springframework.boot</groupId>
+			<artifactId>spring-boot-starter-jersey</artifactId>
+		</dependency>
 	</dependencies>
 
 	<build>

Diff for: src/main/java/com/springbrasil/repository/controller/RepositoryController.java

@@ -6,6 +6,7 @@
 import org.springframework.data.domain.Page;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.MediaType;
+import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
@@ -38,5 +39,11 @@ public Page<Repository> getRepositories(
 			@RequestParam(required=false, defaultValue="10") Integer size) {
 		return repositoryService.getAll(page, size);
 	}
+	
+	@RequestMapping(method = RequestMethod.GET, value = "/repositories/{repository_id}", produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
+	@ResponseStatus(code = HttpStatus.OK)
+	public Repository getRepositories(@PathVariable(name="repository_id") String repositoryId) {
+		return repositoryService.get(repositoryId);
+	}
 
 }

Diff for: src/main/java/com/springbrasil/repository/controller/handler/GlobalExceptionHandler.java

@@ -0,0 +1,33 @@
+package com.springbrasil.repository.controller.handler;
+
+import javax.ws.rs.NotFoundException;
+
+import org.springframework.http.HttpStatus;
+import org.springframework.web.bind.annotation.ControllerAdvice;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.ResponseStatus;
+
+@ControllerAdvice
+public class GlobalExceptionHandler {
+
+	@ResponseStatus(HttpStatus.NOT_FOUND)
+    @ExceptionHandler(NotFoundException.class)
+	@ResponseBody
+    public ErrorMessage handleNotFound(NotFoundException e) {
+		return new ErrorMessage("not found", 
+				String.format("cannot found resource: '%s'", e.getMessage()));
+    }
+	
+	class ErrorMessage {
+		String error;
+		String message;
+		
+		ErrorMessage(String error, String message) {
+			this.error = error;
+			this.message = message;
+		}
+		
+	}
+	
+}

Diff for: src/main/java/com/springbrasil/repository/dao/RepositoryDao.java

@@ -1,9 +1,9 @@
 package com.springbrasil.repository.dao;
 
-import org.springframework.data.repository.PagingAndSortingRepository;
+import org.springframework.data.mongodb.repository.MongoRepository;
 
 import com.springbrasil.repository.model.Repository;
 
-public interface RepositoryDao extends PagingAndSortingRepository<Repository, String>{
+public interface RepositoryDao extends MongoRepository<Repository, String>{
 
 }

Diff for: src/main/java/com/springbrasil/repository/service/RepositoryService.java

@@ -1,5 +1,9 @@
 package com.springbrasil.repository.service;
 
+import java.util.Optional;
+
+import javax.ws.rs.NotFoundException;
+
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.PageRequest;
@@ -22,4 +26,10 @@ public Page<Repository> getAll(Integer page, Integer size) {
 		return repositoryDao.findAll(new PageRequest(page, size));
 	}
 
+	public Repository get(String repositoryId) {
+		return Optional
+				.ofNullable(repositoryDao.findOne(repositoryId))
+				.orElseThrow(() -> new NotFoundException(repositoryId));
+	}
+
 }

Diff for: src/test/java/com/springbrasil/repository/controller/RepositoryControllerUnitTest.java

@@ -1,8 +1,11 @@
 package com.springbrasil.repository.controller;
 
+import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.anyInt;
+import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
@@ -12,8 +15,12 @@
 
 import java.util.Arrays;
 
+import javax.ws.rs.NotFoundException;
+
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
@@ -22,6 +29,7 @@
 import org.springframework.http.MediaType;
 import org.springframework.test.context.junit4.SpringRunner;
 import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.web.util.NestedServletException;
 
 import com.springbrasil.repository.helper.JsonHelper;
 import com.springbrasil.repository.model.Repository;
@@ -39,6 +47,9 @@ public class RepositoryControllerUnitTest {
 	@Autowired
     private MockMvc mvc;
 
+	@Rule
+	public ExpectedException exception = ExpectedException.none();
+	
 	private Repository repository;
 
 	@Before
@@ -49,6 +60,8 @@ public void setUp() {
 		repository.setType(RepositoryType.GITHUB);
 		doReturn(repository).when(repositoryService).save(any(Repository.class));
 		doReturn(new PageImpl<>(Arrays.asList(repository))).when(repositoryService).getAll(anyInt(), anyInt());
+		doReturn(repository).when(repositoryService).get(eq("6e71d0d568e134c029203593b00a0103e7cdf30b"));
+		doThrow(new NotFoundException("unexisting_repository")).when(repositoryService).get(eq("unexisting_repository"));
 	}
 
 	@Test
@@ -74,5 +87,26 @@ public void shouldGetAllRepositories() throws Exception {
 
 		verify(repositoryService, times(1)).getAll(0, 10);
 	}
+	
+	@Test
+	public void shouldGetOneRepository() throws Exception {
+		String response = JsonHelper.getResponseFileAsString("repository/get_one_repository_success.json");
+
+		mvc.perform(get("/repositories/6e71d0d568e134c029203593b00a0103e7cdf30b").accept(MediaType.APPLICATION_JSON_UTF8_VALUE))
+				.andExpect(status().isOk())
+				.andExpect(content().json(response));
+
+		verify(repositoryService, times(1)).get("6e71d0d568e134c029203593b00a0103e7cdf30b");
+	}
+	
+	@Test
+	public void shouldThrowErrorWhenGetUnexistingRepository() throws Exception {
+		exception.expect(NestedServletException.class);
+		exception.expectCause(instanceOf(NotFoundException.class));
+		
+		mvc.perform(get("/repositories/unexisting_repository")
+				.accept(MediaType.APPLICATION_JSON_UTF8_VALUE))
+				.andExpect(status().isNotFound());
+	}
 
 }

Diff for: src/test/java/com/springbrasil/repository/service/RepositoryServiceUnitTest.java

@@ -1,9 +1,14 @@
 package com.springbrasil.repository.service;
 
 import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyString;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 
+import javax.ws.rs.NotFoundException;
+
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -39,5 +44,19 @@ public void shouldFindAllRepositories() {
 
 		verify(repositoryDao, times(1)).findAll(any(PageRequest.class));
 	}
+	
+	@Test
+	public void shouldFindOneRepository() {
+		doReturn(new Repository()).when(repositoryDao).findOne(anyString());
+		repositoryService.get("123");
+		
+		verify(repositoryDao, times(1)).findOne(anyString());
+	}
+	
+	@Test(expected=NotFoundException.class)
+	public void shouldThrowErrorWhenDoesntFindOneRepository() {
+		doReturn(null).when(repositoryDao).findOne(eq("unexisting_repository"));
+		repositoryService.get("unexisting_repository");
+	}
 
 }

Diff for: src/test/resources/json/response/repository/get_one_repository_not_found.json

@@ -0,0 +1,4 @@
+{
+	"error": "not found",
+	"message": "cannot found resource: 'unexisting_resource' "
+}

Diff for: src/test/resources/json/response/repository/get_one_repository_success.json

@@ -0,0 +1,5 @@
+{
+	"id": "6e71d0d568e134c029203593b00a0103e7cdf30b",
+	"url": "http://my_repository",
+	"type": "GITHUB"
+}