Merge pull request #163 from Squads-Protocol/chore/green-build

Updates and cleanups to get tests and CI passing green

Author: sean-sqds

.github/actions/setup-anchor/action.yaml

@@ -22,7 +22,7 @@ runs:
     - if: steps.restore-cache-anchor-cargo.outputs.cache-hit != 'true'
       name: Install Anchor CLI
       shell: bash
-      run: cargo install --git https://github.com/coral-xyz/anchor --tag v${{ env.ANCHOR_VERSION }} anchor-cli --locked
+      run: cargo +1.78.0 install --git https://github.com/coral-xyz/anchor --tag v${{ env.ANCHOR_VERSION }} anchor-cli --locked
 
     - if: steps.restore-cache-anchor-cargo.outputs.cache-hit != 'true'
       name: Save Cargo Cache with Installed Anchor CLI

.github/actions/setup-solana/action.yaml

@@ -19,7 +19,7 @@ runs:
         max_attempts: 10
         retry_on: error
         shell: bash
-        command: sh -c "$(curl -sSfL https://release.solana.com/v${{ env.SOLANA_CLI_VERSION }}/install)"
+        command: sh -c "$(curl -sSfL https://release.anza.xyz/v${{ env.SOLANA_CLI_VERSION }}/install)"
     - run: echo "/home/runner/.local/share/solana/install/active_release/bin" >> $GITHUB_PATH
       shell: bash
     - run: solana-keygen new --no-bip39-passphrase

.github/workflows/tests.yaml

@@ -13,7 +13,7 @@ jobs:
     uses: ./.github/workflows/reusable-tests.yaml
     with:
       cache: true
-      solana_cli_version: 1.18.4
+      solana_cli_version: 1.18.16
       anchor_version: 0.29.0
       node_version: 18
       cargo_profile: debug

programs/squads_multisig_program/src/instructions/spending_limit_use.rs

@@ -89,7 +89,6 @@ pub struct SpendingLimitUse<'info> {
 impl SpendingLimitUse<'_> {
     fn validate(&self) -> Result<()> {
         let Self {
-            multisig,
             member,
             spending_limit,
             mint,

programs/squads_multisig_program/src/instructions/vault_transaction_create.rs

@@ -1,5 +1,4 @@
 use anchor_lang::prelude::*;
-use anchor_lang::system_program;
 
 use crate::errors::*;
 use crate::state::*;

sdk/rs/src/client.rs

@@ -591,7 +591,7 @@ pub mod utils {
                 AccountMeta::new(self.multisig, false),
                 AccountMeta::new_readonly(self.member, true),
                 AccountMeta::new(self.proposal, false),
-                AccountMeta::new(self.transaction, false),
+                AccountMeta::new_readonly(self.transaction, false),
                 if let Some(rent_payer) = self.rent_payer {
                     AccountMeta::new(rent_payer, true)
                 } else {