Skip to content

Commit 87e3450

Browse files
authored
Merge pull request #1295 from pfeigl/fix_signtool_passwords
Strong passwords (anything except [a-zA-Z0-9_]) are now being obfuscated correctly for signtool calls
2 parents 7628aa4 + 1123b01 commit 87e3450

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/Update/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ static async Task signPEFile(string exePath, string signingOpts)
596596
String.Format("sign {0} \"{1}\"", signingOpts, exePath), CancellationToken.None);
597597

598598
if (processResult.Item1 != 0) {
599-
var optsWithPasswordHidden = new Regex(@"/p\s+\w+").Replace(signingOpts, "/p ********");
599+
var optsWithPasswordHidden = new Regex(@"/p\s+\S+").Replace(signingOpts, "/p ********");
600600
var msg = String.Format("Failed to sign, command invoked was: '{0} sign {1} {2}'",
601601
exe, optsWithPasswordHidden, exePath);
602602

0 commit comments

Comments
 (0)