Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delta updates do not work if the target file contains spaces #1898

Open
RareScrap opened this issue Jan 3, 2025 · 1 comment
Open

Delta updates do not work if the target file contains spaces #1898

RareScrap opened this issue Jan 3, 2025 · 1 comment

Comments

@RareScrap
Copy link

Squirrel version(s)
2.0.1

Description
Squirrel.Windows encounters an error when applying delta updates to files with spaces in their names

Steps to recreate

  1. Include some file.txt in your app files
  2. Setup update endpoint
  3. Build a setup executable of the app version 1.0.0
  4. Make change in some file.txt
  5. Up the app version
  6. Build and publish an delta update of the app version 2.0.0
  7. Run the app version 1.0.0
  8. Trigger update mechanism
  9. In Squirrel-Update.log see unability to patch some file.txt and subsequent fallback to update using the full pacakge

Expected behavior
Squirrel.Windows successfully applies delta updates to files with spaces in their names

Actual behavior
Squirrel.Windows encounters an error when applying delta updates to files with spaces in their names

Additional information

(Succeed) Squirrel-Update.log for versions 0.1.0.0 to 0.1.0.1 of my app containing the file named МоеПриложение.exe 
[31/12/24 15:44:51] info: Program: Starting Squirrel Updater: --update https://somehost.com/squirrel.windows/x86_64/0.1.0.1/
[31/12/24 15:44:51] info: Program: Starting update, downloading from https://somehost.com/squirrel.windows/x86_64/0.1.0.1/
[31/12/24 15:44:51] info: Program: About to update to: C:\Users\user\AppData\Local\SomeDeveloper
[31/12/24 15:44:51] info: CheckForUpdateImpl: Using existing staging user ID: 914c43f1-f911-5521-864d-ed1be56f23d9
[31/12/24 15:44:51] info: CheckForUpdateImpl: Downloading RELEASES file from https://somehost.com/squirrel.windows/x86_64/0.1.0.1
[31/12/24 15:44:52] info: FileDownloader: Downloading url: https://somehost.com/squirrel.windows/x86_64/0.1.0.1/RELEASES?id=SomeDeveloper&localVersion=0.1.0&arch=amd64
[31/12/24 15:44:53] info: FileDownloader: Downloading file: https://somehost.com/squirrel.windows/x86_64/0.1.0.1/SomeDeveloper.SomeProject.SomeApp-0.1.1-delta.nupkg
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\chrome_100_percent.pak.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\chrome_200_percent.pak.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\d3dcompiler_47.dll.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\ffmpeg.dll.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\icudtl.dat.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\libEGL.dll.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\libGLESv2.dll.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\LICENSE.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\resources.pak.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\snapshot_blob.bin.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\squirrel.exe.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\v8_context_snapshot.bin.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\vk_swiftshader.dll.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\vk_swiftshader_icd.json.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: lib\net45\vulkan-1.dll.diff exists unchanged, skipping
[31/12/24 15:44:55] info: DeltaPackageBuilder: Applying BSDiff to lib\net45\МоеПриложение.exe.bsdiff
[31/12/24 15:44:58] info: DeltaPackageBuilder: Applying MSDiff to lib\net45\МоеПриложение_ExecutionStub.exe.diff
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\af.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\am.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ar.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\bg.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\bn.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ca.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\cs.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\da.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\de.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\el.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\en-GB.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\en-US.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\es-419.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\es.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\et.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\fa.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\fi.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\fil.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\fr.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\gu.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\he.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\hi.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\hr.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\hu.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\id.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\it.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ja.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\kn.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ko.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\lt.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\lv.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ml.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\mr.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ms.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\nb.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\nl.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\pl.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\pt-BR.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\pt-PT.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ro.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ru.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\sk.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\sl.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\sr.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\sv.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\sw.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ta.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\te.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\th.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\tr.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\uk.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\ur.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\vi.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\zh-CN.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: lib\net45\locales\zh-TW.pak.diff exists unchanged, skipping
[31/12/24 15:44:58] info: DeltaPackageBuilder: Adding new file: lib\net45\resources\app.asar
[31/12/24 15:44:58] info: DeltaPackageBuilder: Updating metadata file: SomeDeveloper.SomeProject.SomeApp.nuspec
[31/12/24 15:44:58] info: DeltaPackageBuilder: Updating metadata file: [Content_Types].xml
[31/12/24 15:44:58] info: DeltaPackageBuilder: Updating metadata file: package\services\metadata\core-properties\a003b38c88e44142a93787e04b7bb3a5.psmdcp
[31/12/24 15:44:58] info: DeltaPackageBuilder: Updating metadata file: _rels\.rels
[31/12/24 15:44:58] info: DeltaPackageBuilder: Repacking into full package: C:\Users\user\AppData\Local\SomeDeveloper\packages\SomeDeveloper.SomeProject.SomeApp-0.1.1.nupkg
[31/12/24 15:45:14] info: ApplyReleasesImpl: Writing files to app directory: C:\Users\user\AppData\Local\SomeDeveloper\app-0.1.1
[31/12/24 15:45:16] info: LogHost: Rigging execution stub for МоеПриложение_ExecutionStub.exe to C:\Users\user\AppData\Local\SomeDeveloper\МоеПриложение.exe
[31/12/24 15:45:17] info: ApplyReleasesImpl: Squirrel Enabled Apps: []
[31/12/24 15:45:17] warn: ApplyReleasesImpl: No apps are marked as Squirrel-aware! Going to run them all
[31/12/24 15:45:17] info: ApplyReleasesImpl: About to create shortcuts for МоеПриложение.exe, rootAppDir C:\Users\user\AppData\Local\SomeDeveloper
[31/12/24 15:45:17] info: ApplyReleasesImpl: Creating shortcut for МоеПриложение.exe => C:\Users\user\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Еще один разработчик\Мое Приложение.lnk
[31/12/24 15:45:17] info: ApplyReleasesImpl: About to save shortcut: C:\Users\user\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Еще один разработчик\Мое Приложение.lnk (target C:\Users\user\AppData\Local\SomeDeveloper\МоеПриложение.exe, workingDir C:\Users\user\AppData\Local\SomeDeveloper\app-0.1.1, args , toastActivatorCSLID 0e803e1e-4718-5eaa-bbe2-73ae868e377c)
[31/12/24 15:45:17] info: ApplyReleasesImpl: Creating shortcut for МоеПриложение.exe => C:\Users\user\Desktop\Мое Приложение.lnk
[31/12/24 15:45:17] info: ApplyReleasesImpl: About to save shortcut: C:\Users\user\Desktop\Мое Приложение.lnk (target C:\Users\user\AppData\Local\SomeDeveloper\МоеПриложение.exe, workingDir C:\Users\user\AppData\Local\SomeDeveloper\app-0.1.1, args , toastActivatorCSLID 0e803e1e-4718-5eaa-bbe2-73ae868e377c)
[31/12/24 15:45:17] info: ApplyReleasesImpl: Starting fixPinnedExecutables
[31/12/24 15:45:17] info: ApplyReleasesImpl: Fixing up tray icons
[31/12/24 15:45:17] info: ApplyReleasesImpl: cleanDeadVersions: checking for version 0.1.1
[31/12/24 15:45:17] info: ApplyReleasesImpl: cleanDeadVersions: exclude current version folder app-0.1.0
[31/12/24 15:45:17] info: ApplyReleasesImpl: cleanDeadVersions: exclude new version folder app-0.1.1
[31/12/24 15:45:18] info: InstallHelperImpl: Couldn't write uninstall icon, don't care: System.Net.WebException: The remote server returned an error: (404) Not Found.
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.WebClient.GetWebResponse(WebRequest request, IAsyncResult result)
   at System.Net.WebClient.DownloadBitsResponseCallback(IAsyncResult result)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.UpdateManager.InstallHelperImpl.<CreateUninstallerRegistryEntry>d__5.MoveNext()
[31/12/24 15:45:18] info: Program: Finished Squirrel Updater
(Failed) Squirrel-Update.log for versions 0.1.0.0 to 0.1.0.1 of my app containing the file named Мое Приложение.exe 
[01/01/25 14:01:33] info: Program: Starting Squirrel Updater: --update https://somehost.com/squirrel.windows/x86_64/0.1.0.1/
[01/01/25 14:01:33] info: Program: Starting update, downloading from https://somehost.com/squirrel.windows/x86_64/0.1.0.1/
[01/01/25 14:01:33] info: Program: About to update to: C:\Users\user\AppData\Local\SomeDeveloper
[01/01/25 14:01:33] info: CheckForUpdateImpl: Using existing staging user ID: 7e851631-8e3a-538b-89c1-1f1d1e76e3fc
[01/01/25 14:01:33] info: CheckForUpdateImpl: Downloading RELEASES file from https://somehost.com/squirrel.windows/x86_64/0.1.0.1
[01/01/25 14:01:33] info: FileDownloader: Downloading url: https://somehost.com/squirrel.windows/x86_64/0.1.0.1/RELEASES?id=SomeDeveloper&localVersion=0.1.0&arch=amd64
[01/01/25 14:01:34] info: FileDownloader: Downloading file: https://somehost.com/squirrel.windows/x86_64/0.1.0.1/SomeDeveloper.SomeProject.SomeApp-0.1.1-delta.nupkg
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\chrome_100_percent.pak.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\chrome_200_percent.pak.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\d3dcompiler_47.dll.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\ffmpeg.dll.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\icudtl.dat.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\libEGL.dll.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\libGLESv2.dll.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\LICENSE.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\resources.pak.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\snapshot_blob.bin.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\squirrel.exe.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\v8_context_snapshot.bin.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\vk_swiftshader.dll.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\vk_swiftshader_icd.json.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: lib\net45\vulkan-1.dll.diff exists unchanged, skipping
[01/01/25 14:01:37] info: DeltaPackageBuilder: Applying BSDiff to lib\net45\Мое Приложение.exe.bsdiff
[01/01/25 14:01:39] warn: Program: Failed to apply updates, falling back to full updates: System.Exception: Invalid release entry: 64A41A451A7C73EBD17A0ED2805DDD01720E1F7A Мое Приложение.exe.shasum 180422472
   at Squirrel.ReleaseEntry.ParseReleaseEntry(String entry)
   at Squirrel.DeltaPackageBuilder.verifyPatchedFile(String relativeFilePath, String inputFile, String tempTargetFile)
   at Squirrel.DeltaPackageBuilder.applyDiffToFile(String deltaPath, String relativeFilePath, String workingDirectory)
   at Squirrel.EnumerableExtensions.ForEach[TSource](IEnumerable`1 source, Action`1 onNext)
   at Squirrel.DeltaPackageBuilder.ApplyDeltaPackage(ReleasePackage basePackage, ReleasePackage deltaPackage, String outputFile, Action`1 progress)
   at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClass8_0.<createFullPackagesFromDeltas>b__4()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.UpdateManager.ApplyReleasesImpl.<createFullPackagesFromDeltas>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.UpdateManager.ApplyReleasesImpl.<ApplyReleases>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.UpdateManager.<ApplyReleases>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Squirrel.Update.Program.<Update>d__5.MoveNext()
[01/01/25 14:01:39] info: CheckForUpdateImpl: Using existing staging user ID: 7e851631-8e3a-538b-89c1-1f1d1e76e3fc
[01/01/25 14:01:39] info: CheckForUpdateImpl: Downloading RELEASES file from https://somehost.com/squirrel.windows/x86_64/0.1.0.1
[01/01/25 14:01:39] info: FileDownloader: Downloading url: https://somehost.com/squirrel.windows/x86_64/0.1.0.1/RELEASES?id=SomeDeveloper&localVersion=0.1.0&arch=amd64
[01/01/25 14:01:39] info: FileDownloader: Downloading file: https://somehost.com/squirrel.windows/x86_64/0.1.0.1/SomeDeveloper.SomeProject.SomeApp-0.1.1-full.nupkg
[01/01/25 14:01:56] info: ApplyReleasesImpl: Writing files to app directory: C:\Users\user\AppData\Local\SomeDeveloper\app-0.1.1
[01/01/25 14:01:58] info: LogHost: Rigging execution stub for Мое Приложение_ExecutionStub.exe to C:\Users\user\AppData\Local\SomeDeveloper\Мое Приложение.exe
[01/01/25 14:01:59] info: ApplyReleasesImpl: Squirrel Enabled Apps: []
[01/01/25 14:01:59] warn: ApplyReleasesImpl: No apps are marked as Squirrel-aware! Going to run them all
[01/01/25 14:01:59] info: ApplyReleasesImpl: About to create shortcuts for Мое Приложение.exe, rootAppDir C:\Users\user\AppData\Local\SomeDeveloper
[01/01/25 14:01:59] info: ApplyReleasesImpl: Creating shortcut for Мое Приложение.exe => C:\Users\user\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Еще один разработчик\Мое Приложение.lnk
[01/01/25 14:01:59] info: ApplyReleasesImpl: About to save shortcut: C:\Users\user\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Еще один разработчик\Мое Приложение.lnk (target C:\Users\user\AppData\Local\SomeDeveloper\Мое Приложение.exe, workingDir C:\Users\user\AppData\Local\SomeDeveloper\app-0.1.1, args , toastActivatorCSLID 0e803e1e-4718-5eaa-bbe2-73ae868e377c)
[01/01/25 14:01:59] info: ApplyReleasesImpl: Creating shortcut for Мое Приложение.exe => C:\Users\user\Desktop\Мое Приложение.lnk
[01/01/25 14:01:59] info: ApplyReleasesImpl: About to save shortcut: C:\Users\user\Desktop\Мое Приложение.lnk (target C:\Users\user\AppData\Local\SomeDeveloper\Мое Приложение.exe, workingDir C:\Users\user\AppData\Local\SomeDeveloper\app-0.1.1, args , toastActivatorCSLID 0e803e1e-4718-5eaa-bbe2-73ae868e377c)
[01/01/25 14:01:59] info: ApplyReleasesImpl: Starting fixPinnedExecutables
[01/01/25 14:01:59] info: ApplyReleasesImpl: Fixing up tray icons
[01/01/25 14:01:59] info: ApplyReleasesImpl: cleanDeadVersions: checking for version 0.1.1
[01/01/25 14:01:59] info: ApplyReleasesImpl: cleanDeadVersions: exclude current version folder app-0.1.0
[01/01/25 14:01:59] info: ApplyReleasesImpl: cleanDeadVersions: exclude new version folder app-0.1.1
[01/01/25 14:02:00] info: InstallHelperImpl: Couldn't write uninstall icon, don't care: System.Net.WebException: The remote server returned an error: (404) Not Found.
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.WebClient.GetWebResponse(WebRequest request, IAsyncResult result)
   at System.Net.WebClient.DownloadBitsResponseCallback(IAsyncResult result)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Squirrel.UpdateManager.InstallHelperImpl.<CreateUninstallerRegistryEntry>d__5.MoveNext()
[01/01/25 14:02:00] info: Program: Finished Squirrel Updater
@RareScrap
Copy link
Author

This happens because the release entry regexp respects only non-space symbols:

^([0-9a-fA-F]{40})\s+(\S+)\s+(\d+)[\r]*$
                      ^
                      |
                      |
            This causes the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RareScrap