Detect destructive Modify() on non-initialized record

[ernestasjuska]

Hi,

Juniors can make silly mistakes like this (in reality code could be much more complex):

    procedure UpgradeStep()
    var
        GeneralLedgerSetup: Record "General Ledger Setup";
    begin
        GeneralLedgerSetup."LBC Allow VAT Posting From" := 0D;
        GeneralLedgerSetup."LBC Allow VAT Posting To" := 0D;
        GeneralLedgerSetup.Modify(false);
    end;

The problem with this code is that General Ledger Setup record exists in pretty much every BC company. Meaning, that this code will execute just fine without any complaints and will clear every field in the record.

Consider adding rule that detects when Modify is used without initializing record first.

Keep in mind that code like this is also possible - it is very difficult to check that GetOrCreate actually initialized the record, so I would prefer some extra check (prefer error over silent destruction of data).

GetOrCreate(SomeRecord); // var parameter
SomeRecord.TestField(Code); // Prove that you have an existing record. For setup tables could use SystemId field.
SomeRecord.SomeField := 123;
SomeRecord.Modify(true);

Thanks.