Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load LoRA in cli_demo.py doesn't work #712

Open
1 of 2 tasks
Vicky0522 opened this issue Feb 19, 2025 · 3 comments
Open
1 of 2 tasks

Load LoRA in cli_demo.py doesn't work #712

Vicky0522 opened this issue Feb 19, 2025 · 3 comments
Assignees

Comments

@Vicky0522
Copy link

System Info / 系統信息

I used the train_ddp_i2v.sh script to finetune LoRA, then loaded the saved LoRA weights with the --load_lora argument in cli_demo.py. However, the outputs look exactly the same as those produced without LoRA, despite seeing correct results during validation in the training process. It appears that the --load_lora option isn’t functioning as intended.

Information / 问题信息

  • The official example scripts / 官方的示例脚本
  • My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程

  1. use train_ddp_i2v.sh script to finetune LoRA
  2. load LoRA via cli_demo.py

Expected behavior / 期待表现

The results should be the same as the results during validation in the training process.

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR self-assigned this Feb 20, 2025
@holma91
Copy link

holma91 commented Feb 24, 2025

Thought I was going insane when I saw such a difference between wandb and locally! Can confirm that this is a bug for me aswell.

@zRzRzRzRzRzRzR
Copy link
Member

We are reviewing this pull request and will respond soon.

@JuheonYi
Copy link

Hi, were you able to fully reproduce the validation results with the fix? Even after applying the scale correctly, there are still some difference...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants