Missing permissions requests and improvements

[milindgoel15]

When installing scoop for first time, it doesn't ask for permissions for reading logs.

And upon tapping permissions in settings, i think it should show a dialog which tells how to give this permission.

[TacoTheDank]

Forgot to post this. READ_LOGS is a protected permission, so it's not a request that the system will show to you through a dialog. There's no other way to tell if an app has this permission granted except through a third party app manager, the app's behavior (Scoop deals with this through the permission setting), or through ADB. That's why the only way to grant the permission is either through root or ADB.

Info: https://developer.android.com/reference/android/Manifest.permission#READ_LOGS

For the second point, I can simply add a 'Help' button for that.

[milindgoel15]

Forgot to post this. READ_LOGS is a protected permission, so it's not a request that the system will show to you through a dialog.

It used to show on earlier versions. Even on paphonb builds iirc. That's why I remembered we had that dialog when we clean install the app which it doesn't anymore.

[TacoTheDank]

It used to show on earlier versions. Even on paphonb builds iirc. That's why I remembered we had that dialog when we clean install the app which it doesn't anymore.

Wait, are we talking about a dialog created by the actual Android system? Or do you mean a dialog that is shown by Magisk (or some other SU application) that asks you to grant?

[milindgoel15]

Wait, are we talking about a dialog created by the actual Android system? Or do you mean a dialog that is shown by Magisk (or some other SU application) that asks you to grant?

It was created by scoop. It used to say, that root or adb permission is required to run scoop (something like this). I will try installing an older build to check

Edit: the old builds of paphonb doesn't even open anymore. Straight up crashes lol

[TacoTheDank]

that root or adb permission is required to run scoop (something like this)

Do you mean the "y u no" rage comic meme image? That's just a background vector that shows when Scoop doesn't have access to the READ_LOGS permission. Scoop itself doesn't have a dialog that appears at launch.

(I didn't even add the meme image btw, it was already in the codebase and I decided to keep it because why not lol)

[milindgoel15]

Ah yes, now i remembered. Yep it was that.
It doesn't show on the latest release when we clean install the apk.

It just shows "wanna make something crash" even with read logs permission denied.

From paphonb scoop build

[N3koSempai]

Forgot to post this. READ_LOGS is a protected permission, so it's not a request that the system will show to you through a dialog.

It used to show on earlier versions. Even on paphonb builds iirc. That's why I remembered we had that dialog when we clean install the app which it doesn't anymore.

It would be more intuitive if clicking on permission status would show a dialog window with the following message and link.

Instructions to activate the permission. https://github.com/TacoTheDank/Scoop/wiki