Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for per-app notification control #52

Open
ZenerDeveloper opened this issue Apr 29, 2022 · 6 comments
Open

Add functionality for per-app notification control #52

ZenerDeveloper opened this issue Apr 29, 2022 · 6 comments
Labels
new functionality A new functionality is requested

Comments

@ZenerDeveloper
Copy link

I think that it would be very useful to have not only the ability to blacklist an app, but to have a specific notification channel per package to have fine-grained control over how the user receives a notification. A good implementation would to have a notification channel group called "Crashes" and to have sub channels for each app like "F-Droid" or "Messages" and each app could have a description associated like "Crash channel for org.fdroid.fdroid". It would be best for the feature to be opt in (default 1 channel) and to have the ability to set defaults for newly added apps (sound, vibrate, silent). It would also be nice to have the option for crashes of the same app forming a group in the notification shade to clean up some space(also opt in / out).
I don't know how many people would find this useful, but I have a lot of apps that crash often that I would still like to see reports of, just without my phone vibrating every ten minutes.

@TacoTheDank
Copy link
Owner

TacoTheDank commented Apr 29, 2022

This was pretty hard to understand at first, but I think I get it now. I believe what you're asking for is the ability to disable notifications for certain apps (or customize them).

However, doing that via notification channels is a VERY bad way of implementing that sort of thing.

Also, if you have an app blacklisted, it means you aren't receiving crash notifications for that app anyway. However, the crashes are still stored in the list. This is evident by how, when you remove the app from the blacklist, you can see the new crashlogs from the app on the main screen. So all you have to do really is add the app you want to ignore to the blacklist (although the reports for it will be hidden). <- Fixed with e8fad1f

At least, that's how it'll work for the app in its current state. I may consider adding notification controlling functionality for a rewrite (which is planned). However, if done, it won't be through notification channels.

@TacoTheDank TacoTheDank changed the title Add per app notification channel. Add functionality for per-app notification control Apr 29, 2022
@TacoTheDank TacoTheDank added the enhancement Enhancement to existing feature or functionality label Apr 29, 2022
@X1nto
Copy link
Contributor

X1nto commented Apr 29, 2022

I think this is the same as #48, though I'm not entirely sure.

@TacoTheDank
Copy link
Owner

TacoTheDank commented Apr 29, 2022

@X1nto The concern in that issue, I believe, is that they want the ability to blacklist future crash notifications from the notification action buttons itself (because their blacklist is large, apparently). That's obviously not something that I think makes sense (duplicate functionality in separate parts of the app).

But they brought up another point that the activity refreshes when the screen is rotated. Thus, I've repurposed that issue to be closed when the app is rewritten to use ViewModels (but a temporary fix would also work). I should change the issue title.

@X1nto
Copy link
Contributor

X1nto commented Apr 29, 2022

@X1nto The concern in that issue, I believe, is that they want the ability to blacklist future crash notifications from the notification action buttons itself (because their blacklist is large, apparently). That's obviously not something that I think makes sense (duplicate functionality in separate parts of the app).

But they brought up another point that the activity refreshes when the screen is rotated. Thus, I've repurposed that issue to be closed when the app is rewritten to use ViewModels (but a temporary fix would also work). I should change the issue title.

I see.

@TacoTheDank TacoTheDank added new functionality A new functionality is requested and removed enhancement Enhancement to existing feature or functionality labels Apr 29, 2022
@ZenerDeveloper
Copy link
Author

when you remove the app from the blacklist, you can see the new crashlogs from the app on the main screen.

Assuming I am interpreting this correctly, I don't think this is accurate. Adding an app to the blacklist it still save the logs but you have to remove it to view them at all. It doesn't show blacklisted apps on the main page.

doing that via notification channels is a VERY bad way of implementing that sort of thing.

I agree, but I don't know if there is any other way to have per-app vibrate/popup settings so that is all I could think of.

I also think a grouped notification would be nice to tidy up the panel, and the documentation seems to make it look simple to implement, but I don't know.

@TacoTheDank
Copy link
Owner

Adding an app to the blacklist it still save the logs but you have to remove it to view them at all. It doesn't show blacklisted apps on the main page.

That is what I meant lol, I just worded it in a confusing way.

I agree, but I don't know if there is any other way to have per-app vibrate/popup settings so that is all I could think of.

I'll have to see if there's a way to support it with the Android APIs, though I doubt it's possible. I'll research when I'm done with my semester in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new functionality A new functionality is requested
Projects
None yet
Development

No branches or pull requests

3 participants