New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Sentry Code #39

Open

joseph-lozano opened this issue Mar 5, 2025 · 0 comments

joseph-lozano commented Mar 5, 2025

Which project does this relate to?

Create Tanstack App

Describe the bug

It seems that there is duplicate Sentry init code when creating a project with the Sentry and Start add-ons.

The duplicate code exists in https://github.com/TanStack/create-tsrouter-app/blob/174920a38362150f7b477350856c602f397e95e7/templates/react/add-on/start/assets/src/router.tsx.ejs#L23C1-L45C8

as well as https://github.com/TanStack/create-tsrouter-app/blob/174920a38362150f7b477350856c602f397e95e7/templates/react/add-on/sentry/assets/src/app/global-middleware.ts#L5C1-L25C5

Your Example Website or App

N/A

Steps to Reproduce the Bug or Issue

Init a project selecting both the Start and Sentry add-ons

Expected behavior

There is only one init call of the Sentry code

Screenshots or Videos

No response

Platform

OS: macOS
Browser: N/A
Version: 0.6.1

Additional context

I'm happy to make a PR, but unsure which block should be preferred

icflorescu mentioned this issue

Type errors in generated src/router.tsx (with TanStack Start & Query) #51

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment