From 0b1a575ae87b273e2e4f64e2fc5dc874081e4ea2 Mon Sep 17 00:00:00 2001 From: Sebastian Jeltsch Date: Wed, 17 Dec 2025 13:23:52 +0100 Subject: [PATCH 1/2] Remove misleading schema arguments (#1002) and backfill missing mock stubs. --- examples/react/todo/src/lib/collections.ts | 2 -- examples/solid/todo/src/lib/collections.ts | 2 -- .../tests/trailbase.test.ts | 29 +++++++++++++++++++ 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/examples/react/todo/src/lib/collections.ts b/examples/react/todo/src/lib/collections.ts index 689372b80..e8154c5a2 100644 --- a/examples/react/todo/src/lib/collections.ts +++ b/examples/react/todo/src/lib/collections.ts @@ -132,7 +132,6 @@ export const trailBaseTodoCollection = createCollection( trailBaseCollectionOptions({ id: `todos`, getKey: (item) => item.id, - schema: selectTodoSchema, recordApi: trailBaseClient.records(`todos`), // Re-using the example's drizzle-schema requires remapping the items. parse: { @@ -233,7 +232,6 @@ export const trailBaseConfigCollection = createCollection( trailBaseCollectionOptions({ id: `config`, getKey: (item) => item.id, - schema: selectConfigSchema, recordApi: trailBaseClient.records(`config`), // Re-using the example's drizzle-schema requires remapping the items. parse: { diff --git a/examples/solid/todo/src/lib/collections.ts b/examples/solid/todo/src/lib/collections.ts index fa7ce9530..e252809e5 100644 --- a/examples/solid/todo/src/lib/collections.ts +++ b/examples/solid/todo/src/lib/collections.ts @@ -120,7 +120,6 @@ export const trailBaseTodoCollection = createCollection( trailBaseCollectionOptions({ id: `todos`, getKey: (item) => item.id, - schema: selectTodoSchema, recordApi: trailBaseClient.records(`todos`), // Re-using the example's drizzle-schema requires remapping the items. parse: { @@ -215,7 +214,6 @@ export const trailBaseConfigCollection = createCollection( trailBaseCollectionOptions({ id: `config`, getKey: (item) => item.id, - schema: selectConfigSchema, recordApi: trailBaseClient.records(`config`), // Re-using the example's drizzle-schema requires remapping the items. parse: { diff --git a/packages/trailbase-db-collection/tests/trailbase.test.ts b/packages/trailbase-db-collection/tests/trailbase.test.ts index a6d282a30..a31ad48e8 100644 --- a/packages/trailbase-db-collection/tests/trailbase.test.ts +++ b/packages/trailbase-db-collection/tests/trailbase.test.ts @@ -2,11 +2,20 @@ import { describe, expect, it, vi } from 'vitest' import { createCollection } from '@tanstack/db' import { trailBaseCollectionOptions } from '../src/trailbase' import type { + CreateOperation, + DeleteOperation, Event, FilterOrComposite, + ListOperation, + ListOpts, ListResponse, Pagination, + ReadOperation, + ReadOpts, RecordApi, + RecordId, + SubscribeOpts, + UpdateOperation, } from 'trailbase' type Data = { @@ -27,6 +36,9 @@ class MockRecordApi implements RecordApi { return Promise.resolve({ records: [] }) }, ) + listOp = vi.fn((_opts?: ListOpts): ListOperation => { + throw `listOp` + }); read = vi.fn( ( @@ -38,6 +50,9 @@ class MockRecordApi implements RecordApi { throw `read` }, ) + readOp = vi.fn((_id: RecordId, _opt?: ReadOpts): ReadOperation => { + throw `readOp` + }) create = vi.fn((_record: T): Promise => { throw `create` @@ -45,13 +60,24 @@ class MockRecordApi implements RecordApi { createBulk = vi.fn((_records: Array): Promise> => { throw `createBulk` }) + createOp = vi.fn((_record: T): CreateOperation => { + throw `createOp` + }) update = vi.fn((_id: string | number, _record: Partial): Promise => { throw `update` }) + updateOp = vi.fn((_id: RecordId, _record: Partial): UpdateOperation => { + throw `updateOp` + }); + delete = vi.fn((_id: string | number): Promise => { throw `delete` }) + deleteOp = vi.fn((_id: RecordId): DeleteOperation => { + throw `deleteOp` + }) + subscribe = vi.fn((_id: string | number): Promise> => { return Promise.resolve( new ReadableStream({ @@ -61,6 +87,9 @@ class MockRecordApi implements RecordApi { }), ) }) + subscribeAll = vi.fn((_opts?: SubscribeOpts): Promise> => { + throw `subscribeAll` + }) } function setUp(recordApi: MockRecordApi) { From f23904349d2dad905f969eb0f2ffe019d61694b2 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Wed, 17 Dec 2025 12:32:11 +0000 Subject: [PATCH 2/2] ci: apply automated fixes --- .../trailbase-db-collection/tests/trailbase.test.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/trailbase-db-collection/tests/trailbase.test.ts b/packages/trailbase-db-collection/tests/trailbase.test.ts index a31ad48e8..f59605394 100644 --- a/packages/trailbase-db-collection/tests/trailbase.test.ts +++ b/packages/trailbase-db-collection/tests/trailbase.test.ts @@ -38,7 +38,7 @@ class MockRecordApi implements RecordApi { ) listOp = vi.fn((_opts?: ListOpts): ListOperation => { throw `listOp` - }); + }) read = vi.fn( ( @@ -69,7 +69,7 @@ class MockRecordApi implements RecordApi { }) updateOp = vi.fn((_id: RecordId, _record: Partial): UpdateOperation => { throw `updateOp` - }); + }) delete = vi.fn((_id: string | number): Promise => { throw `delete` @@ -87,9 +87,11 @@ class MockRecordApi implements RecordApi { }), ) }) - subscribeAll = vi.fn((_opts?: SubscribeOpts): Promise> => { - throw `subscribeAll` - }) + subscribeAll = vi.fn( + (_opts?: SubscribeOpts): Promise> => { + throw `subscribeAll` + }, + ) } function setUp(recordApi: MockRecordApi) {