New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`throwOnError` is still on `MutationObserverOptions` #8569

Open

AlexErrant opened this issue Jan 22, 2025 · 0 comments

Contributor

AlexErrant commented Jan 22, 2025 •

edited

Loading

query/packages/query-core/src/types.ts

Line 1079 in 4a0a129

throwOnError?: boolean | ((error: TError) => boolean)

I believe this should be removed since it doesn't do anything (I think) and is confusing to new users like me.

Then mutate would return nothing, mutateAsync would return a promise and throwOnError can be removed. Src.

Would you accept a PR removing it, or is there a reason it's still there?

The text was updated successfully, but these errors were encountered:

AlexErrant mentioned this issue

better document throwOnError's default #8581

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment