Fixing issue with override parameter, and added a new one for stopping post all together.

Author: jasonconnery

CHANGELOG.markdown

@@ -1,3 +1,6 @@
+# 4.4.0
+* Added support for teamcity configuration parameter "system.POST_TO_SLACK" to supress posts from config level instead of project level by setting it to false or 0. Fixed bug with existing system.SLACK_CHANNEL param name for overwriting settings at the config level.
+
 # 4.3.0
 * Bumped up Teamcity library versions to 2018
 

build.gradle

@@ -11,7 +11,7 @@ apply plugin: 'java'
 
 
 sourceCompatibility = 1.8
-version = '4.3.0'
+version = '4.4.0'
 
 configurations {
     deploy

src/main/java/com/tapadoo/slacknotifier/SlackServerAdapter.java

@@ -42,7 +42,6 @@ public SlackServerAdapter(SBuildServer sBuildServer, ProjectManager projectManag
         this.projectSettingsManager = projectSettingsManager ;
         this.buildServer = sBuildServer ;
         this.slackConfig = configProcessor ;
-
     }
 
     public void init()
@@ -74,6 +73,13 @@ public void buildStarted(SRunningBuild build) {
     public void buildFinished(SRunningBuild build) {
         super.buildFinished(build);
 
+
+        String postToSlack = build.getParametersProvider().get("system.POST_TO_SLACK");
+
+        if(postToSlack != null && (postToSlack.equals("false") || postToSlack.equals("0") )) {
+            return ;
+        }
+
         if( !build.isPersonal() && build.getBuildStatus().isSuccessful() && slackConfig.postSuccessful() )
         {
             processSuccessfulBuild(build);
@@ -167,7 +173,7 @@ private void postToSlack(SRunningBuild build, String message, boolean goodColor)
                 iconUrl = slackConfig.getLogoUrl() ;
             }
 
-            String configuredChannel = build.getParametersProvider().get("SLACK_CHANNEL");
+            String configuredChannel = build.getParametersProvider().get("system.SLACK_CHANNEL");
             String channel = this.slackConfig.getDefaultChannel();
 
             if( configuredChannel != null && configuredChannel.length() > 0 )

teamcity-plugin.xml

@@ -4,7 +4,7 @@
     <info>
         <name>slackNotifier</name> <!-- the name of plugin used in teamcity -->
         <display-name>Slack Notifier</display-name>
-        <version>4.3.0</version>
+        <version>4.4.0</version>
         <description>Post build success notifications to Slack</description>
         <vendor>
             <name>Tapadoo</name>