Skip to content

Commit e18a6b0

Browse files
committed
Apply new itag filter only to YouTube streams
1 parent f8c3ec4 commit e18a6b0

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

app/src/main/java/org/schabi/newpipe/player/resolver/AudioPlaybackResolver.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,14 @@ public MediaSource resolve(@NonNull final StreamInfo info) {
6868
*/
6969
@Nullable
7070
private Stream getAudioSource(@NonNull final StreamInfo info) {
71-
final List<AudioStream> audioStreams = getPlayableStreams(info.getAudioStreams());
71+
final List<AudioStream> audioStreams = getPlayableStreams(
72+
info.getAudioStreams(), info.getServiceId());
7273
if (!audioStreams.isEmpty()) {
7374
final int index = ListHelper.getDefaultAudioFormat(context, audioStreams);
7475
return getStreamForIndex(index, audioStreams);
7576
} else {
76-
final List<VideoStream> videoStreams = getPlayableStreams(info.getVideoStreams());
77+
final List<VideoStream> videoStreams = getPlayableStreams(
78+
info.getVideoStreams(), info.getServiceId());
7779
if (!videoStreams.isEmpty()) {
7880
final int index = ListHelper.getDefaultResolutionIndex(context, videoStreams);
7981
return getStreamForIndex(index, videoStreams);

app/src/main/java/org/schabi/newpipe/player/resolver/VideoPlaybackResolver.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ public MediaSource resolve(@NonNull final StreamInfo info) {
7272

7373
// Create video stream source
7474
final List<VideoStream> videoStreamsList = ListHelper.getSortedStreamVideosList(context,
75-
getPlayableStreams(info.getVideoStreams()),
76-
getPlayableStreams(info.getVideoOnlyStreams()), false, true);
75+
getPlayableStreams(info.getVideoStreams(), info.getServiceId()),
76+
getPlayableStreams(info.getVideoOnlyStreams(), info.getServiceId()), false, true);
7777
final int index;
7878
if (videoStreamsList.isEmpty()) {
7979
index = -1;
@@ -100,7 +100,8 @@ public MediaSource resolve(@NonNull final StreamInfo info) {
100100
}
101101

102102
// Create optional audio stream source
103-
final List<AudioStream> audioStreams = getPlayableStreams(info.getAudioStreams());
103+
final List<AudioStream> audioStreams = getPlayableStreams(
104+
info.getAudioStreams(), info.getServiceId());
104105
final AudioStream audio = audioStreams.isEmpty() ? null : audioStreams.get(
105106
ListHelper.getDefaultAudioFormat(context, audioStreams));
106107

app/src/main/java/org/schabi/newpipe/util/ListHelper.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.schabi.newpipe.util;
22

3+
import static org.schabi.newpipe.extractor.ServiceList.YouTube;
4+
35
import android.content.Context;
46
import android.content.SharedPreferences;
57
import android.net.ConnectivityManager;
@@ -162,16 +164,19 @@ public static <S extends Stream> List<S> getUrlAndNonTorrentStreams(
162164
* Some formats are not supported. For more info, see {@link #SUPPORTED_ITAG_IDS}.
163165
* Torrent streams are also removed, because they cannot be retrieved.
164166
*
165-
* @param streamList the original stream list
166167
* @param <S> the item type's class that extends {@link Stream}
168+
* @param streamList the original stream list
169+
* @param serviceId
167170
* @return a stream list which only contains streams that can be played the player
168171
*/
169172
@NonNull
170173
public static <S extends Stream> List<S> getPlayableStreams(
171-
@Nullable final List<S> streamList) {
174+
@Nullable final List<S> streamList, final int serviceId) {
175+
final int youtubeServiceId = YouTube.getServiceId();
172176
return getFilteredStreamList(streamList,
173177
stream -> stream.getDeliveryMethod() != DeliveryMethod.TORRENT
174-
&& (stream.getItagItem() == null
178+
&& (serviceId != youtubeServiceId
179+
|| stream.getItagItem() == null
175180
|| SUPPORTED_ITAG_IDS.contains(stream.getItagItem().id)));
176181
}
177182

0 commit comments

Comments
 (0)