Optimize UI #11435
Open
Optimize UI #11435
+36
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fixes the UI padding issue - Why use a constant height that too inside a constraint layout? Use a fixed aspect ratio instead.
- Bold style for comment author
TobiGr
added
GUI
|
acrodemocide
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Optimize the existing layout and how they work in the app with various accessibility improvements.
Before/After Screenshots/Screen Record
The list is optimized, the titles have better visibility and channel names have been italicized.
The grid list were incorrectly laid out in the app, the icons weren't evenly placed and have weird spacing, the same could be fixed easily by removing the fixed width and height constants and applying aspect ratio based resizing for the thumbnails. The rest of the changes were the same as list view.
The title has been emphasized, and comment usernames have better visibility now. The emphasis from the "X REPLIES" have been reduced to lower case so that it can be a little less loud.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence