Skip to content

[YouTube] SRT numbering should start at 1 (currently starts at 0) #12670

@TransZAllen

Description

@TransZAllen

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.28.0 and all earlier versions

Description

Currently, into YouTube, the downloaded .srt subtitle files start numbering at 0. For example:

0
00:00:00,640 --> 00:00:07,160
This mother has three young cubs just 8

Although most players (mpv, VLC, MPlayer, Totem) can still display them correctly, this is NOT compliant with the SubRip (.srt) specification, which requires numbering to start at 1.

Here is the specification: SubRip (https://en.wikipedia.org/wiki/SubRip), and it says:

Subtitles are numbered sequentially, starting at 1.

Tested players:

  • mpv 0.37.0 ✅ works with 0
  • VLC 3.0.20 ✅ works with 0, even -1
  • MPlayer 1.5 ✅ works with 0
  • Totem 43.0 ✅ works with 0

Even though playback works fine, some stricter software or tools may reject these *.srt files. So I think it's best to fix it.

Expected behavior

No response

Actual behavior

This issue can be reproduced by any downloaded *.srt file.
Here is an example of YouTube video link ( https://www.youtube.com/watch?v=Q8aPwoe_iMc ), let's look at the beginning of a *.SRT file generated by NewPipe:

a51x:/storage/emulated/0/Newpipe $ cat Bear\ Family\ Searches\ for\ Water\ _\ Wild\ Mexico\ _\ BBC\ Earth-en.srt
0
00:00:00,640 --> 00:00:07,160
This mother has three young cubs just 8

1
00:00:03,840 --> 00:00:07,160
months old.

2
00:00:08,520 --> 00:00:22,899
[Music]

3
00:00:24,560 --> 00:00:29,039
It's autumn and the family needs to

4
00:00:27,119 --> 00:00:32,039
flatten up before the winter

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue is related to a bugdownloaderIssue is related to the downloader

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions