Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using pushState routing, encodeURI should be used instead of encodeURIComponent #124

Open
TehShrike opened this issue Dec 4, 2018 · 0 comments
Open

When using pushState routing, encodeURI should be used instead of encodeURIComponent #124

TehShrike opened this issue Dec 4, 2018 · 0 comments
Labels
bug

Comments

@TehShrike
Copy link
Owner

Reported by stalkerg in chat.

https://github.com/TehShrike/page-path-builder/blob/93a1c9130f6e17aa22689084b010ceecd7444b77/index.js#L20

Current thought on how to fix it: update page-path-builder to take an encode function as an option, and then add encode as an initialization option for ASR as well
@TehShrike TehShrike added the bug label Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TehShrike