Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-picker): 修复滑动saturation后点击swatch不生效的问题 #1962

Closed
wants to merge 1 commit into from

Conversation

novlan1
Copy link
Contributor

@novlan1 novlan1 commented Oct 9, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(color-picker): 修复滑动saturation后点击swatch不生效的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@novlan1
Copy link
Contributor Author

novlan1 commented Oct 9, 2024

修复 bug:点击某个预设的颜色,然后调整saturation,然后再点同一个预设颜色,点击无效

https://tdesign.tencent.com/vue/components/color-picker

@HaixingOoO
Copy link
Collaborator

react也遇到這個問題,但是目前react有個判斷相同值時也有點問題
image

@novlan1
Copy link
Contributor Author

novlan1 commented Oct 11, 2024

react也遇到這個問題,但是目前react有個判斷相同值時也有點問題 image

@HaixingOoO
Copy link
Collaborator

也是new Color的update判斷相同值時導致的連鎖反應

@novlan1
Copy link
Contributor Author

novlan1 commented Oct 11, 2024 via email

@HaixingOoO
Copy link
Collaborator

试一下吧,看

https://stackblitz.com/edit/react-fy5y49-nq1gfr?file=src%2Findex.js
可以測試一下,點擊color-picker -> 在面板saturation隨便點擊一下 -> 然後點擊下面重置按鈕 -> 查看log
要是你修改了new Color的update,就再重試一下查看log

@novlan1 novlan1 closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants