Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 版本问题 #655

Closed
dianjie opened this issue Dec 13, 2023 · 4 comments
Closed

Node 版本问题 #655

dianjie opened this issue Dec 13, 2023 · 4 comments
Assignees

Comments

@dianjie
Copy link
Contributor

dianjie commented Dec 13, 2023

这个功能解决了什么问题

项目指定Node版本为:
https://github.com/Tencent/tdesign-vue-next-starter/blob/develop/package.json#L93

"engines": {
  "node": ">=16.0.0"
}

开发分支的这些依赖

"@commitlint/cli": "^18.4.1",
"@commitlint/config-conventional": "^18.4.0",
"lint-staged": "^15.1.0",

不支持Node.js 16。

"@commitlint/cli": "^17.8.1",
"@commitlint/config-conventional": "^17.8.1",
"lint-staged": "^14.0.1",

这些版本才支持。

你建议的方案是什么

依赖降级?还是修改指定的Node版本

Copy link
Contributor

👋 @dianjie,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

Copy link
Contributor

github-actions bot commented Dec 13, 2023

♥️ 有劳 @timi137137 @liweijie0812 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @dianjie

@timi137137
Copy link
Collaborator

其实本身就不应该使用nodejs18以下,这一点在内部也经过了一段时间的讨论,目前我能给到的建议是使用nodejs18

@dianjie
Copy link
Contributor Author

dianjie commented Dec 13, 2023

其实本身就不应该使用nodejs18以下,这一点在内部也经过了一段时间的讨论,目前我能给到的建议是使用nodejs18

那这样的话,应该把engines改一下吧

"engines": {
 "node": ">=18.0"
},

@dianjie dianjie closed this as completed Dec 18, 2023
@timi137137 timi137137 mentioned this issue Jan 10, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants