Skip to content

Commit c75b74d

Browse files
committed
Remove extra test_install_exclude_* tests
The three tests test_install_exclude_* were covering the same code path. Since tests execution requires considerable amount of time it is reasonable to not to repeat tests.
1 parent e5628a1 commit c75b74d

File tree

1 file changed

+4
-24
lines changed

1 file changed

+4
-24
lines changed

tests/product/test_package_install.py

+4-24
Original file line numberDiff line numberDiff line change
@@ -50,35 +50,15 @@ def test_install_using_dash_h(self):
5050
self.installer.assert_uninstalled(self.cluster.slaves[0], msg=output)
5151
self.installer.assert_uninstalled(self.cluster.slaves[2], msg=output)
5252

53-
def test_install_exclude_coord(self):
53+
def test_install_exclude_nodes(self):
5454
rpm_name = self.installer.copy_presto_rpm_to_master()
5555
output = self.run_prestoadmin('package install /mnt/presto-admin/'
56-
'%(rpm)s -x %(master)s', rpm=rpm_name)
57-
58-
self.installer.assert_uninstalled(self.cluster.master, msg=output)
59-
for slave in self.cluster.slaves:
60-
self.installer.assert_installed(self, slave, msg=output)
61-
62-
def test_install_exclude_worker(self):
63-
rpm_name = self.installer.copy_presto_rpm_to_master()
64-
output = self.run_prestoadmin('package install /mnt/presto-admin/'
65-
'%(rpm)s -x %(slave1)s', rpm=rpm_name)
66-
self.installer.assert_uninstalled(self.cluster.slaves[0], msg=output)
67-
self.installer.assert_installed(self, self.cluster.slaves[1],
68-
msg=output)
69-
self.installer.assert_installed(self, self.cluster.master, msg=output)
70-
self.installer.assert_installed(self, self.cluster.slaves[2],
71-
msg=output)
72-
73-
def test_install_exclude_workers(self):
74-
rpm_name = self.installer.copy_presto_rpm_to_master()
75-
output = self.run_prestoadmin('package install /mnt/presto-admin/'
76-
'%(rpm)s -x %(slave1)s,%(slave2)s',
56+
'%(rpm)s -x %(master)s,%(slave2)s',
7757
rpm=rpm_name)
7858

79-
self.installer.assert_uninstalled(self.cluster.slaves[0], msg=output)
59+
self.installer.assert_uninstalled(self.cluster.master, msg=output)
8060
self.installer.assert_uninstalled(self.cluster.slaves[1], msg=output)
81-
self.installer.assert_installed(self, self.cluster.master, msg=output)
61+
self.installer.assert_installed(self, self.cluster.slaves[0], msg=output)
8262
self.installer.assert_installed(self, self.cluster.slaves[2],
8363
msg=output)
8464

0 commit comments

Comments
 (0)