Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: improve lootr compat #1598

Open
3 tasks done
Alexmasonseals opened this issue Jul 31, 2023 · 4 comments
Open
3 tasks done

Feature Request: improve lootr compat #1598

Alexmasonseals opened this issue Jul 31, 2023 · 4 comments
Assignees
@bconlon1
Labels
affects/mod This issue affects another mod. feat/art This issue is associated with art. status/blocked This issue depends on another issue being resolved first. status/dependent This issue requires changes in external API. type/compatibility The issue regards a compatibility or additional feature request relating to another mod. type/design The issue pertains to the design of a feature rather than a bug in the implementation of a design. type/request The issue is a feature or change request and does not fit into the other types.
Milestone
Post-Release Feat...

Comments

@Alexmasonseals
Copy link

What Feature Types Apply to This Request?

Other (Please Describe)

Other Type

mod compat

Is This an Enhancement to a Preexisting Feature?

  • I confirm this request is an enhancement to a feature already in The Aether.

What Is Your Feature Request?

make boss chests compatible with lootr

Why Should It Be in the Mod?

it enhances multiplayer experience

Does This Feature Improve Compatibility With Another Mod?

yeah -w-

Please Read and Confirm the Following

  • I have confirmed this feature is either in the original Aether mod, or improves parity between The Aether and Minecraft or other mods.
  • I have confirmed this suggestion is unique and has not been suggested already.
@Alexmasonseals Alexmasonseals added the type/request The issue is a feature or change request and does not fit into the other types. label Jul 31, 2023
@bconlon1 bconlon1 added affects/mod This issue affects another mod. type/compatibility The issue regards a compatibility or additional feature request relating to another mod. labels Jul 31, 2023
@bconlon1 bconlon1 added this to the beta.6 Update milestone Jul 31, 2023
@bconlon1 bconlon1 added the type/design The issue pertains to the design of a feature rather than a bug in the implementation of a design. label Jul 31, 2023
@bconlon1 bconlon1 added status/in-progress The issue is currently being worked on. and removed status/in-progress The issue is currently being worked on. labels Aug 9, 2023
@bconlon1 bconlon1 added version/1.20.1 This issue affects Minecraft version 1.20.1. and removed status/in-progress The issue is currently being worked on. labels Aug 10, 2023
@bconlon1
Copy link
Contributor

Can't implement compatibility for Treasure Chests without Lootr 1.20.1's api.

@bconlon1 bconlon1 added status/dependent This issue requires changes in external API. status/blocked This issue depends on another issue being resolved first. labels Aug 10, 2023
@bconlon1 bconlon1 removed status/dependent This issue requires changes in external API. status/blocked This issue depends on another issue being resolved first. labels Aug 21, 2023
@bconlon1
Copy link
Contributor

Will need custom Treasure Chest textures for this eventually.

@bconlon1 bconlon1 added the feat/art This issue is associated with art. label Aug 23, 2023
@bconlon1
Copy link
Contributor

https://github.com/TelepathicGrunt/Bumblezone/blob/1.20-Arch/forge/src/main/java/com/telepathicgrunt/the_bumblezone/modcompat/forge/LootrCompatImpl.java may be a useful reference.

@bconlon1 bconlon1 added the status/in-progress The issue is currently being worked on. label Sep 9, 2023
@bconlon1 bconlon1 mentioned this issue Sep 9, 2023
Merged
1 task
@bconlon1
Copy link
Contributor

The 1.20.1 Lootr API is not workable or documented enough to add integration.

@bconlon1 bconlon1 added status/blocked This issue depends on another issue being resolved first. status/dependent This issue requires changes in external API. and removed status/in-progress The issue is currently being worked on. labels Sep 12, 2023
@bconlon1 bconlon1 removed the version/1.20.1 This issue affects Minecraft version 1.20.1. label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bconlon1 bconlon1

Labels
affects/mod This issue affects another mod. feat/art This issue is associated with art. status/blocked This issue depends on another issue being resolved first. status/dependent This issue requires changes in external API. type/compatibility The issue regards a compatibility or additional feature request relating to another mod. type/design The issue pertains to the design of a feature rather than a bug in the implementation of a design. type/request The issue is a feature or change request and does not fit into the other types.
Projects
The Aether
Status: Back Log
Milestone
Post-Release Features
Development

No branches or pull requests
3 participants
@OzPayn @bconlon1 @Alexmasonseals