Add cache with LIFO replacement policy #6390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6390 +/- ##
============================================
+ Coverage 74.86% 75.05% +0.19%
- Complexity 5482 5517 +35
============================================
Files 682 683 +1
Lines 19012 19166 +154
Branches 3670 3693 +23
============================================
+ Hits 14233 14385 +152
Misses 4224 4224
- Partials 555 557 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KevinMwita7
requested review from
DenizAltunkapan,
yanglbme,
vil02 and
alxkm
as code owners
|
|
||
| while (it.hasNext()) { | ||
| K k = it.next(); | ||
| CacheEntry<V> entry = cache.get(k); |
There was a problem hiding this comment.
Try using the final keyword for local variables where possible @KevinMwita7
There was a problem hiding this comment.
Done @DenizAltunkapan
| private LIFOCache(Builder<K, V> builder) { | ||
| this.capacity = builder.capacity; | ||
| this.defaultTTL = builder.defaultTTL; | ||
| this.cache = HashMap.newHashMap(builder.capacity); |
There was a problem hiding this comment.
I didn't know there is such static method... A suggestion could be using the classic constructor new HashMap<>(builder.capacity)
There was a problem hiding this comment.
I think it was introduced in Java 19. But I've changed it to in which java version was HashMap.newHashMap introduced
Description
This PR adds a reusable LIFOCache implementation with the following features:
Fixed size LIFO eviction policy using Deque as stack and HashMap as cache
Time to live (TTL)
Thread-safe operations using ReentrantLock
Pluggable EvictionStrategy to control expired entry cleanup
Eviction listener callback support for observing removals
Hit and miss statistics tracking
Builder for flexible configuration
I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
All new code is formatted with
clang-format -i --style=file path/to/your/file.java