Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Can't Drown if Health Regain On #489

Open
Teabone3 opened this issue Feb 10, 2019 · 2 comments
Open

Player Can't Drown if Health Regain On #489

Teabone3 opened this issue Feb 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Teabone3
Copy link
Contributor

The player cannot drown under water if he is set to regain health.

For example set the following settings for the start player marker:

Regeneration Rate: 1
Regeneration Speed: 100
Regeneration Delay: 3000

Health Regeneration should be ignored while the player is below the surface of water.

@GameGuruEvan GameGuruEvan added the bug Something isn't working label Feb 11, 2019
@LeeBamberTGC LeeBamberTGC added enhancement New feature or request and removed bug Something isn't working labels Jun 27, 2019
@LeeBamberTGC
Copy link
Contributor

This could be classified as a FEATURE addition as the current rules allow regen to keep the player alive under water. This enhancement would suggest a new flag in Start Marker to disable regen when the player is underwater,

@Teabone3
Copy link
Contributor Author

Teabone3 commented Mar 13, 2025

Hi Lee I've now fixed the issue and added a pull request: #5939

If any options were to be added to the start marker in the future, it would be to toggle this new "feature" off, rather than on.

The main issue was that the player was being prevented from drowning, when users had expected drowning to be enabled while also having the ability to auto regenerate health when injured in combat, hurt zones, fall damage etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants