Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client to be extended with custom-made controllers #213

Open
1 task done
fdionisi opened this issue Apr 30, 2024 · 1 comment · Fixed by #240
Open
1 task done

Allow client to be extended with custom-made controllers #213

fdionisi opened this issue Apr 30, 2024 · 1 comment · Fixed by #240
Assignees
Labels
enhancement New feature or request triage Newly created issue that needs maintainers validation

Comments

@fdionisi
Copy link
Member

Check for existing issues

  • Completed

Describe the feature

The current client supports the standards EDC contexts, but when working within dataspaces there are likely extensions providing additional functionalities (e.g., BPN validation or Resources Count API).

Would be great if we could reuse EdcConnectorClient plumbing to allow the class to be extended with additional controllers.

If applicable, add text / mockups / screenshots to help present your vision of the feature

There's some TypeScript-related research to be done to make this composition and typing possible (perhaps taking inspiration by Express.js/Koa middleware systems).

The hope is to have a fully typed solution such that:

const client = new EdcConnectorClient.Builder()
  .managementUrl("https://edc.think-it.io/management")
  .build()
  .use("bpnValidator", BpnValidatorController);

await client.bpnValidator.resolve(bpnString);
@fdionisi fdionisi added enhancement New feature or request triage Newly created issue that needs maintainers validation labels Apr 30, 2024
@ndr-brt
Copy link
Contributor

ndr-brt commented Feb 17, 2025

This feature should be documented

@ndr-brt ndr-brt reopened this Feb 17, 2025
@ndr-brt ndr-brt self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Newly created issue that needs maintainers validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants