While exporting, Auto disable plugin on error

[linonetwo]

One user in our QQ group reported echarts plugin blocks exporting. (This happened on my side too)

From the error stack, we can see the $:/plugins/Gk0wk/echarts

So I guide this user to disabling the echarts plugin, continuing his exportion.

I think one solution to this can be Auto disable plugins that show up in the error stack, and Auto reenable them after export, what do you think?

[pmario]

Hi,

It would be nice to have a "To reproduce" step by step info, so we are able to reproduce the problem ourselves.

Otherwise my advice will be as follows:

I think the right thing to do, would be to fix the problem in the plugin instead of creating a workaround in the core.

[Jermolene]

Hi @linonetwo

I think one solution to this can be Auto disable plugins that show up in the error stack, and Auto reenable them after export, what do you think?

The trouble is that we can't disable JS modules in plugins without a reload; there's no way to disable plugins once they've executed.

The usual escape hatch when it is not possible to save or export would be to use a bookmarklet to copy the JSON of all tiddlers to the clipboard, from where it can be saved in a file. It would be helpful perhaps to publish that bookmarklet on tiddlywiki.com

[linonetwo]

Oh, I forget this...

In this case, user just want the HTML export. Maybe I can refine that error message to guide user try disabling the plugin. (Instead of needing to open dev tool and ask in the group)

[pmario]

I did test to create a New Tiddler at: https://tiddly-gittly.github.io/tw-echarts/ ... When I do save the tiddler, the whole wiki is automatically saved as a file. ... So it seems something has been done with the auto-save function because that's not standard. It doesn't work that way at tiddlywiki.com

For me it seems the "click" event "tm-download-file" is broken. It seems the event.propagation isn't stopped.

[pmario]

I did try:

title: New Tiddler

<<echarts "$:/plugins/Gk0Wk/echarts/addons/SimpleExample.json">>

Export Tiddler : Static HTML

is the echarts-macro able to export it's output as a static image?

[linonetwo]

Yes, maybe this is better get fixed from @Gk0Wk 's side. He have some effort to make exporting work. I don'k know why standard "tm-download-file" is not working now.

[pmario]

I did single step through the saving mechanism. It seemed to create the message and also activated the save actions, but then it seemed to go on with .dispatchEvent() ... It seems this event bubbles up until there is no parent node anymore. ... At least, that's what I think