[BUG] upgrader site has contradictory message, seemingly refuses to upgrade

[twMat]

Describe the bug

As reported by a user it is confusing that the officially recommended upgrade mechanism on https://tiddlywiki.com/upgrade seemingly blocks to upgrade the very core plugin. (I explain why in the linked to post). This:

Expected behavior

No response

To Reproduce

1. Drag an outdated TW onto the upgrader mechanism at https://tiddlywiki.com/upgrade

Screenshots

No response

TiddlyWiki Configuration

Additional context

I note the upgrade wiki has a special Upgrade plugin so maybe, for that very url, there could be some exception to how this is handled?

[pmario]

hmm, The response

Yes, that is what I’m seeing. That makes sense now. I initially was thinking that the upgrade would update my outdated modules, but it sounds like it just doesn’t import my outdated modules.

is right. ... The upgrader uses the same import mechanism as every other TW. That's good for maintainability. ... We shouldn't change the mechanism ... but ...

We should be able to replace https://github.com/Jermolene/TiddlyWiki5/blob/3fd2cfc33918e9f8f75bcdcb17dedeee8435c152/core/language/en-GB/Import.multids#L24
with a different text in the upgrade plugin. It already contains some adjustments for other core templates.

@twMat What new text would you suggest?

[pmario]

May be: Your plugin <<incoming>> will be upgraded with <<existing>>

What do you think?

[twMat]

How about

Your plugin will be upgraded from <<incoming>> to <<existing>>

:)

[Jermolene]

Changing the text of the status messages in the import listing will be quite an undertaking.

Perhaps we could add some text at the top of the listing that provides a better context for the messages rather than changing the messages themselves.

[twMat]

Changing the text of the status messages in the import listing will be quite an undertaking.

I don't know the extent of this, but considering how we're only talking about a single plugin, and the most important one at that, maybe it can be presented separately above the listing with an appropriate message. And below, the listing makes an exception by not listing that plugin?

[pmario]

Changing the text of the status messages in the import listing will be quite an undertaking.

I don't think so. .. We do have the upgrade plugin, which can overwrite the message. It's a translatable message. So it should be doable

[pmario]

It should be a simple fix, since the Upgrader is English Only at the moment. I don't think there is a translated version out there.

And if there is one, they can add the new tiddler to the edition and translate it.

[twMat]

BTW, is this only relevant for the core plugin? What about snowwhite and vanilla?

[pmario]

BTW, is this only relevant for the core plugin? What about snowwhite and vanilla?

They have a different text which imo does make sense

[pmario]

Or do you want to change all of them. There are here

https://github.com/Jermolene/TiddlyWiki5/blob/3fd2cfc33918e9f8f75bcdcb17dedeee8435c152/core/language/en-GB/Import.multids#L23-L34

[twMat]

OK, testing it again, I conclude that only the core plugin prompt is problematic.

[Jermolene]

It would be possible for the upgrader to overwrite the language strings in question, but that would make it impossible to translate the upgrader.

I really think we're over engineering the fix to this very minor problem. In the first instance we should be trying to fix this by improving the text in a general way that works both for imports and the upgrader.

[pmario]

It would be possible for the upgrader to overwrite the language strings in question, but that would make it impossible to translate the upgrader.

There is a pending draft PR, that would allow us to translate plugins. ... So I don't see a real problem there in the future ;)

[pmario]

I really think we're over engineering the fix to this very minor problem. In the first instance we should be trying to fix this by improving the text in a general way that works both for imports and the upgrader.

We will need to have a closer look. .. I think it may be possible to find a wording, that works for both cases in English. I'm not so sure if that will work for German.