Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Core variants of various types #510

Open
21 tasks
antiguru opened this issue Mar 6, 2023 · 0 comments
Open
21 tasks

Remove Core variants of various types #510

antiguru opened this issue Mar 6, 2023 · 0 comments

Comments

@antiguru
Copy link
Member

antiguru commented Mar 6, 2023

We added several Core variants of types to support different container types. For example, Stream<G, D> is really a StreamCore<G, Vec<D>>. We should remove the Core variants and make them the default instead.

This is a breaking change, but it seems we have sufficient experience with the container abstraction that we can make the container type with its contents to the default stream element.

The following types need to be adjusted:

  • StreamCore
  • TeeCore
  • EventProducerCore
  • EventConsumerCore
  • BundleCore
  • ParallelizationContractCore
  • ExchangeCore
  • BufferCore
  • AutoflushSessionCore
  • CounterCore
  • feedback::HandleCore
  • input::HandleCore
  • UnorderedHandleCore
  • EventIteratorCore
  • EventPusherCore
  • EventLinkCore
  • EventWriterCore
  • EventReaderCore
  • InputHandleCore
  • FrontierdInputHandleCore
  • OutputHandleCore
@antiguru antiguru mentioned this issue Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove core antiguru/timely-dataflow
1 participant
@antiguru